Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UiSettings client side validation #83038

Closed
mshustov opened this issue Nov 10, 2020 · 3 comments · Fixed by #100311
Closed

Remove UiSettings client side validation #83038

mshustov opened this issue Nov 10, 2020 · 3 comments · Fixed by #100311
Assignees
Labels
:ml Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Nov 10, 2020

We added server-side validation for UiSettings to cover cases when settings changed via API & kibana.yml config.

schema: Type<T>;

I managed to find only two last plugins relying on the deprecated client-side validation:

Plugins should migrate to the server-side validation.
The core should remove legacy client-side validation support.

@mshustov mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@peteharverson
Copy link
Contributor

Note the regexString validation has been moved from the ml plugin to the file_upload plugin and is now in x-pack/plugins/file_upload/server/plugin.ts.

@mshustov
Copy link
Contributor Author

mshustov commented May 6, 2021

@peteharverson thank you, I updated the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants