-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new terms enum API for autocomplete value suggestions #100174
Use new terms enum API for autocomplete value suggestions #100174
Conversation
A heads up on how the API evolved - rather than hard-coding that tier filtering logic into the terms_enum API we changed that and made filtering a responsibility of the calling client. The client should filter indices by using a query on the new
Note that the queries used above are a rough filter on whole indices and not individual documents when it comes to where we look for term suggestions (i.e. we might suggest terms originating from docs outside of the provided date range if the docs sit in an index whose time span partially matches the index filter). |
…o migrate-autocomplete-config
fd57f55
to
cb0ef5e
Compare
@markharwood I've added it as a kibana.yml setting and defaulted it to |
adding |
+1 to add |
Pinging @elastic/kibana-app-services (Team:AppServices) |
@lukasolson, afaik it is not necessary to update |
ef001ef
to
741add8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maps changes LGTM
code review
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change look good, work well!
💔 Backport failed
To backport manually run: |
…0174) * Migrate kibana.autocomplete config to data plugin * Fix CI * Fix tests * Use new terms enum API for autocomplete value suggestions * Add tiers to config * Re-introduce terms agg and add config/tests for swapping algorithms * Add data_content and data_cold tiers by default * Fix types * Fix maps test * Update tests Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/server/autocomplete/value_suggestions_route.ts
…103798) * Migrate kibana.autocomplete config to data plugin * Fix CI * Fix tests * Use new terms enum API for autocomplete value suggestions * Add tiers to config * Re-introduce terms agg and add config/tests for swapping algorithms * Add data_content and data_cold tiers by default * Fix types * Fix maps test * Update tests Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # src/plugins/data/server/autocomplete/value_suggestions_route.ts
Summary
Requires #100586.
Resolves #92783.
Resolves #97512.
Uses the new terms enum API for a faster autocomplete experience.
Note that currently, the autocomplete only targets warm and hot data tiers. By default, indices are given
data_content
tier, so to update this, you need to do something like this:To do
Checklist
Release note
Value suggestions for KQL autocomplete and creating filters now use the Elasticsearch _terms_enum API for improved performance.