Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter value suggestions takes long time to load #97512

Closed
AlonaNadler opened this issue Apr 19, 2021 · 8 comments · Fixed by #100174
Closed

Filter value suggestions takes long time to load #97512

AlonaNadler opened this issue Apr 19, 2021 · 8 comments · Fixed by #100174
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@AlonaNadler
Copy link

Describe the feature:
Filter suggestions are extremely helpful, however value suggestions can take a long time to load

The query to load the drop-down appears to
(a.) draw from all records that match the index filter (regardless of the filtered time range)
(b.) it doesn’t cache these records; repeat visits to the same dropdown engender further delay.

suggestion: Filter suggestions should take into consideration the filters already applied (time range, other filters currently applied)

Also, can client-side caching help? with repeat visits? cc: @timroes / @nreese

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 19, 2021
@timroes timroes added Team:AppServices Feature:Filters and removed needs-team Issues missing a team label labels Apr 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@Dosant
Copy link
Contributor

Dosant commented Apr 20, 2021

Looks like the feedback comes from 7.10.2?

@lizozom
Copy link
Contributor

lizozom commented Apr 21, 2021

@Dosant We're not filtering value suggestions by time range, only the autocomplete suggestions. Imagine what would happen if you:

  1. Set a filter
  2. Change the timerange
  3. Edit the filter

The filter would appear broken and if you make a mistake, you might not be able to change the value back, if you don't re-adjust the time range.

I think users still need a reliable way to get a full, exhaustive list of possible values (maybe with the exception of cold storage), and even the new autocomplete API wouldn't be able to help with that (as it's not an exhaustive API).

@Dosant
Copy link
Contributor

Dosant commented Apr 21, 2021

@lizozom, thanks, looks like I missed the difference between KQL autocomplete and filter value suggestions mentioned in this issue 🤦‍♂️

@lizozom
Copy link
Contributor

lizozom commented Apr 21, 2021

Should be resolved by #92783 (combining an autocomplete API call without any term string with some kind of a UI indication to show that results are incomplete)

@nreese
Copy link
Contributor

nreese commented Apr 21, 2021

Should be resolved by #92783 (combining an autocomplete API call without any term string with some kind of a UI indication to show that results are incomplete)

#92783 is targeting 7.14.0. This issue is a blocker for 7.13.0. What can we do in 7.13.0 to fix this problem?

@nreese
Copy link
Contributor

nreese commented Apr 21, 2021

Disregard last comment. Cross posted from another issue. Sorry for the noise

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels May 13, 2021
@lukasolson
Copy link
Member

Closing in favor of #92783.

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jun 9, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants