Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Allow wildcards in Lens field filter #97459

Closed
Tracked by #137779
flash1293 opened this issue Apr 19, 2021 · 6 comments · Fixed by #155540
Closed
Tracked by #137779

[Lens] Allow wildcards in Lens field filter #97459

flash1293 opened this issue Apr 19, 2021 · 6 comments · Fixed by #155540
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Lens Feature:UnifiedFieldList The unified field list component used by Lens & Discover good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Right now the field name search in Lens is only looking for sub strings
Screenshot 2021-04-19 at 15 38 16

This works fine for known prefixes/suffixes, but often users know parts of the field name with unknown parts in between. Like this:
Screenshot 2021-04-19 at 15 38 30

This mostly happens if the ingested documents is deeply nested and not the whole path is known, like with metricbeat data - a user might think something "I know it's about apache and I know it's about requests, but no idea about where in the path these show up".

Elasticsearch field filters allow this, and
https://github.com/elastic/kibana/blob/master/src/plugins/kibana_utils/common/field_wildcard.ts#L29

implements this functionality on the client.

We should allow to use wildcards like this to make it easier to find the right field.
@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Apr 19, 2021
Closed
@flash1293 flash1293 added the good first issue low hanging fruit label Jun 17, 2021
@stratoula stratoula added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Feb 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula
Copy link
Contributor

Adding the discovery team here too as this is an ER for the shared field list

@jughosta is this on the roadmap?

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Feb 15, 2023
@jughosta jughosta added the Feature:UnifiedFieldList The unified field list component used by Lens & Discover label Feb 15, 2023
@jughosta
Copy link
Contributor

@stratoula I don't think it was discussed.
Thanks for tagging us!

@jughosta jughosta mentioned this issue Feb 15, 2023
Closed
31 tasks
@davismcphee davismcphee added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Feb 15, 2023
@kertal
Copy link
Member

kertal commented Apr 13, 2023 •
edited
Loading

@jughosta wanna take care of it, it's a small but very useful feature?

@stratoula
Copy link
Contributor

It is ❤️

@jughosta jughosta mentioned this issue Apr 21, 2023
Merged
1 task
jughosta added a commit that referenced this issue Apr 25, 2023
@jughosta
[UnifiedFieldList] Allow wildcards in field search (#155540)
c5d6364 
Closes #97459

## Summary

This PR allows to search by field names with wildcard.

<img width="318" alt="Screenshot 2023-04-24 at 10 47 18"
src="https://user-images.githubusercontent.com/1415710/233946401-5588b757-9ba7-4e4f-adda-4ad4a936f528.png">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Lens Feature:UnifiedFieldList The unified field list component used by Lens & Discover good first issue low hanging fruit impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UnifiedFieldList] Allow wildcards in field search jughosta/kibana
6 participants
@kertal @jughosta @flash1293 @elasticmachine @stratoula @davismcphee