Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Allow wildcards in field search #155540

Merged
merged 12 commits into from
Apr 25, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 21, 2023

Closes #97459

Summary

This PR allows to search by field names with wildcard.

Screenshot 2023-04-24 at 10 47 18

Checklist

@jughosta jughosta added release_note:enhancement backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Apr 21, 2023
@jughosta jughosta self-assigned this Apr 21, 2023
@jughosta jughosta marked this pull request as ready for review April 24, 2023 10:07
@jughosta jughosta requested a review from a team as a code owner April 24, 2023 10:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"One small PR for Kibana, one giant leap for UX"
User Armstrong (with many long similar fields)
works great

@jughosta jughosta requested a review from a team April 24, 2023 12:56
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
unifiedFieldList 91 92 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedFieldList 50.8KB 51.0KB +157.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 395 398 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 475 478 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, works great! LGTM 👍

@jughosta jughosta merged commit c5d6364 into elastic:main Apr 25, 2023
@jughosta jughosta deleted the 97459-fields-wildcard-search branch April 25, 2023 08:06
@jughosta jughosta mentioned this pull request Apr 26, 2023
19 tasks
jughosta added a commit that referenced this pull request Oct 11, 2023
…ike wildcards (#168381)

- Closes #165821
- Extends the wilcard logic from
#155540

## Summary

This PR allows to flexibly search in the fields sidebar with terms
containing spaces.

<img width="329" alt="Screenshot 2023-10-09 at 18 28 00"
src="https://github.com/elastic/kibana/assets/1415710/67cbcee8-f6fd-4067-8340-42bec7fd5ec7">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <[email protected]>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
…ike wildcards (elastic#168381)

- Closes elastic#165821
- Extends the wilcard logic from
elastic#155540

## Summary

This PR allows to flexibly search in the fields sidebar with terms
containing spaces.

<img width="329" alt="Screenshot 2023-10-09 at 18 28 00"
src="https://github.com/elastic/kibana/assets/1415710/67cbcee8-f6fd-4067-8340-42bec7fd5ec7">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:UnifiedFieldList The unified field list component used by Lens & Discover release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Allow wildcards in Lens field filter
5 participants