Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] Logo missing at specific breakpoints #6699

Closed
w33ble opened this issue Mar 29, 2016 · 4 comments
Closed

[Design] Logo missing at specific breakpoints #6699

w33ble opened this issue Mar 29, 2016 · 4 comments
Assignees
@panda01
Labels
bug Fixes for quality problems that affect the customer experience v5.0.0

Comments

@w33ble
Copy link
Contributor

w33ble commented Mar 29, 2016

I think this says it all:

2016-03-29 16_23_19
@w33ble w33ble added bug Fixes for quality problems that affect the customer experience v5.0.0 labels Mar 29, 2016
@panda01
Copy link
Contributor

panda01 commented Mar 29, 2016

This is because the brand smallLogo isn't set any longer. But this begs a bigger question. Are we still allowing people to change the branding with kibana?

Do we want people to be able to change the K and kibana to whatever they want?

As a sidenote it would still have the pink background, unless they changed that somewhere else.

@kimjoar
Copy link
Contributor

kimjoar commented Mar 30, 2016

For us changing the logo can be valuable (e.g. in the case where we run without any other Kibana plugins, even visualize et al), so I'm very much +1 on keeping that feature.

@rashidkpc
Copy link
Contributor

Yes, we're still allowing plugins to change the logo. And yeah, we don't need the break point there anymore.

@panda01 panda01 mentioned this issue Apr 4, 2016
Merged
@panda01
Copy link
Contributor

panda01 commented Apr 4, 2016

Whoops misjudged this. Simple style change, should have the same functionality as beforehand.

jbudz added a commit that referenced this issue Apr 18, 2023
@breehall @kibanamachine @jbudz
Upgrade EUI to v77.1.1 (#154838)
3259647 
EUI `77.0.0` ➡️ `77.1.1`

## [`77.1.0`](https://github.com/elastic/eui/tree/v77.1.0)

- Updated `EuiDatePicker` to display a warning icon and correctly set
`aria-invalid` when `isInvalid` is passed
([#6677](elastic/eui#6677))
- Updated `EuiFilePicker` to display an alert icon when `isInvalid`
([#6678](elastic/eui#6678))
- Updated `EuiTextArea` to display an alert icon when `isInvalid`
([#6679](elastic/eui#6679))
- Updated `EuiTextArea` to support the `isLoading` prop
([#6679](elastic/eui#6679))
- Updated `EuiComboBox` to display a warning icon and correctly set
`aria-invalid` when `isInvalid` is passed
([#6680](elastic/eui#6680))

**Bug fixes**

- Fixed `EuiAccordion` to not set an `aria-expanded` attribute on
non-interactive `buttonElement`s
([#6694](elastic/eui#6694))
- Fixed an `EuiPopoverFooter` bug causing nested popovers within
popovers (note: not a recommended use-case) to unintentionally override
its panel padding size inherited from context
([#6698](elastic/eui#6698))
- Fixed `EuiComboBox` to only delete the last selected item on backspace
if the input caret is present
([#6699](elastic/eui#6699))

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Jon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panda01 panda01

Labels
bug Fixes for quality problems that affect the customer experience v5.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kimjoar @w33ble @panda01 @rashidkpc