Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Log rate analysis tab title and URL incorrect #49198

Closed
weltenwort opened this issue Oct 24, 2019 · 1 comment · Fixed by #49646
Closed

[Logs UI] Log rate analysis tab title and URL incorrect #49198

weltenwort opened this issue Oct 24, 2019 · 1 comment · Fixed by #49646
Assignees
@weltenwort
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0

Comments

@weltenwort
Copy link
Member

Problem description

With the upcoming addition of a "Categories" tab, the log rate analysis tab title should be called "Log Rate" instead of "Analysis".

Acceptance criteria

  • The log rate analysis tab title is "Log Rate" with a beta badge.
  • The URL also contains an indication of the fact that this tab relates to the log rate, e.g. /logs/log-rate-analysis.
@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Oct 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort self-assigned this Oct 29, 2019
@weltenwort weltenwort mentioned this issue Oct 29, 2019
Merged
2 tasks
weltenwort added a commit that referenced this issue Oct 30, 2019
@weltenwort
[Logs UI] Fix log rate analysis tab title and route (#49646)
019ee92 
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates.

fixes #49198
weltenwort added a commit to weltenwort/kibana that referenced this issue Oct 30, 2019
@weltenwort
[Logs UI] Fix log rate analysis tab title and route (elastic#49646)
84476fc 
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates.

fixes elastic#49198
weltenwort added a commit to weltenwort/kibana that referenced this issue Oct 30, 2019
@weltenwort
[Logs UI] Fix log rate analysis tab title and route (elastic#49646)
1c4eb6d 
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates.

fixes elastic#49198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Logs UI] Fix log rate analysis tab title and route weltenwort/kibana
3 participants
@sgrodzicki @weltenwort @elasticmachine