[Logs UI] Fix log rate analysis tab title and route #49646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
commented
Oct 29, 2019
| 'This feature is under active development. Extra functionality is coming, and some functionality may change.', | ||
| }); | ||
|
|
||
| export const TabBetaBadge = euiStyled(EuiBetaBadge).attrs({ |
There was a problem hiding this comment.
I factored this out in anticipation of the upcoming categorization tab.
There was a problem hiding this comment.
Are any other teams going to need a beta-badged tab component? Wondering if we should open a PR to EUI
There was a problem hiding this comment.
Worth a thought. Although I think for an "official" badged tab I feel it would require more polish. The position and weight don't really feel like an annotation to me.
weltenwort
commented
Oct 29, 2019
| @@ -152,3 +113,25 @@ export const LogsPage = injectUICapabilities(({ match, uiCapabilities }: LogsPag | |||
| </Source.Context.Provider> | |||
| ); | |||
| }); | |||
|
|
|||
| const pageTitle = i18n.translate('xpack.infra.header.logsTitle', { | |||
There was a problem hiding this comment.
This deduplicates some translations and removes the repeated translation from the render cycle.
💚 Build Succeeded |
weltenwort
added
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
added
the
release_note:skip
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 30, 2019
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates. fixes elastic#49198
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 30, 2019
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from `analysis` to `log-rate` and performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from `/logs/analysis` to `/logs/log-rate` to reduce confusion in the build candidates. fixes elastic#49198
weltenwort
added a commit
that referenced
this pull request
Oct 30, 2019
weltenwort
added a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This aligns the log rate analysis tab title with the requirements. It also changes the sub-route from
analysistolog-rateand performs some additional cleanup in anticipation of the soon-to-be-added category analysis tab. The page redirects from/logs/analysisto/logs/log-rateto reduce confusion in the build candidates.fixes #49198
Preview
Checklist
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately