-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Show non-metric details on node detail page #42689
Comments
Pinging @elastic/infra-logs-ui |
@hbharding @sorantis Your input here would be most welcome! |
@skh, I think the SIEM's Hosts page for hosts looks good for our purpose and hopefully will be easy to reuse. As a bonus we'll gain some consistency across the apps and apply to other cloud providers. Thoughts? Would be great to also have a similar overview page for other entities - Kubernetes, Docker, Host, but that's a different story :) |
@sorantis I like ALT2 better as it shows the most important additional information even in the collapsed state, and it's clearer that there is something to uncollapse.
This element would be on every node detail page, so we already have meta information for every node type. The easiest way to find out which data is already there is to open the network tab in the dev console in the browser, find the call to Depending on which type of node you're looking at, you'll see slightly different information there. If something is missing, please say so, it might be trivial to add. |
+1 The metadata looks good. Will host tags become part of this metadata? Also, would be great to distinguish between system tags and user tags in UI. |
@skh looking at my setup with only one host - my machine, can't find @simianhacker agreed. Where and how is Generally, isn't it so that we'd need to revisit cc @kaiyan-sheng. |
@sorantis You may need to refresh the page with the dev tools open to see the request to the |
Yes, whenever we want to show more data in the UI, we need to adapt our own API endpoints. This may happen when (Please note that these endpoints are part of the Infrastructure app in Kibana. They are executed on the Kibana server (the nodejs part of Kibana) and are responsible to put together the correct elasticsearch queries, which then grab the data from Elasticsearch that has been put there by |
Of course. I did that too. I just filtered the results on my screenshot to make sure I'm not missing any UPDATE: Looks like a version mismatch. #notetoself, always specify the Kibana version. |
I forgot to mention, In earlier versions, similar information is returned by one of the calls to the |
Hi there. I think the mockups @sorantis provided are fine. I've cleaned them up a little and used the proper size for the The only thing I'm unable to wrap my head around is what data do we show by default in the contracted state, and in what order? I imagine each node type could have its own unique metadata that doesn't apply to other node types. If possible, it'd be nice if in the contracted state we could always show the same key/values for consistency. Figma link: https://www.figma.com/file/NIsuFRMURBKr9S292etQ4J/42689-Host-Metadata?node-id=0%3A1 |
In some situations we use different fields for a node "name" and a node "id". The id fields are configurable, their defaults are in https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/infra/server/lib/sources/defaults.ts, the name fields come from https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/infra/server/lib/constants.ts . By default, the configured id fields are: If they are different, we use whatever is in the "name" field as the page title, and in that case I think it would make sense to also show whatever is in the "id" field in either the contracted or the extended state. This is admittedly a bit messy because it only applies to containers and pods as long as the configuration hasn't been touched. Also, the My proposal for a first implementation would therefore be the following. All field names refer to the Candidates for the contracted state:
In the expanded state:
Candidates to be added to the
@sorantis @hbharding what do you think? |
@skh I'd consider swapping +1 on adding IP addresses. Are we able to pull AWS tags into the |
- Closes elastic#42689 - Adds NodeDetails component
* [Infra UI] Display non-metric details on Node Detail page - Closes #42689 - Adds NodeDetails component * clean things up a bit * Change hook order * Start of docs changes * Making expand button more consitent * Update docs for this minor change * Changing handleClick to toggleIsOpen * Optimizing fields slice
) * [Infra UI] Display non-metric details on Node Detail page - Closes elastic#42689 - Adds NodeDetails component * clean things up a bit * Change hook order * Start of docs changes * Making expand button more consitent * Update docs for this minor change * Changing handleClick to toggleIsOpen * Optimizing fields slice
…46049) * [Infra UI] Display non-metric details on Node Detail page - Closes #42689 - Adds NodeDetails component * clean things up a bit * Change hook order * Start of docs changes * Making expand button more consitent * Update docs for this minor change * Changing handleClick to toggleIsOpen * Optimizing fields slice
We have been asked to show more information than metrics on the node detail page:
We currently have this type of information available (from the
metadata
endpoint), this could possibly be extended if more information is desired:Currently, the node detail page only shows metrics:
A possible source of inspiration could be the top part of the Host information page in the SIEM app:
The text was updated successfully, but these errors were encountered: