Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Visualization blows up when incorrect color is passed to background color picker. #190657

Closed
mbondyra opened this issue Aug 16, 2024 · 1 comment · Fixed by #190658
Closed

[TSVB] Visualization blows up when incorrect color is passed to background color picker. #190657

mbondyra opened this issue Aug 16, 2024 · 1 comment · Fixed by #190658
Assignees
@mbondyra
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

main

  1. Open tsvb editor
  2. go to panel options and then edit background color with the invalid color:
Screenshot 2024-08-16 at 11 20 02
  1. There's no way to recover the vis, unless refreshing the whole page.
    Actually we had a test that caught that but we skipped it. I'll unskip it when fixing this problem.
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@mbondyra mbondyra mentioned this issue Aug 16, 2024
Merged
@mbondyra mbondyra self-assigned this Aug 16, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 19, 2024
@mbondyra
[TSVB] Visualization blows up when invalid color is passed (elastic#1…
50748c8 
…90658)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784

## Summary

Fixes elastic#190657
Fixes elastic#182136

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit f8e873f)
kibanamachine referenced this issue Aug 19, 2024
@kibanamachine @mbondyra
[8.15] [TSVB] Visualization blows up when invalid color is passed (#1…
f726e59 
…90658) (#190693)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[TSVB] Visualization blows up when invalid color is passed
(#190658)](#190658)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-19T12:27:06Z","message":"[TSVB]
Visualization blows up when invalid color is passed
(#190658)\n\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784\r\n\r\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190657\r\nFixes
https://github.com/elastic/kibana/issues/182136\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f8e873f87d15014a6f5364482e72ef3ff67e46ad","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","backport:prev-minor","v8.16.0"],"title":"[TSVB]
Visualization blows up when invalid color is
passed","number":190658,"url":"https://github.com/elastic/kibana/pull/190658","mergeCommit":{"message":"[TSVB]
Visualization blows up when invalid color is passed
(#190658)\n\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784\r\n\r\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190657\r\nFixes
https://github.com/elastic/kibana/issues/182136\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f8e873f87d15014a6f5364482e72ef3ff67e46ad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190658","number":190658,"mergeCommit":{"message":"[TSVB]
Visualization blows up when invalid color is passed
(#190658)\n\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784\r\n\r\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190657\r\nFixes
https://github.com/elastic/kibana/issues/182136\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f8e873f87d15014a6f5364482e72ef3ff67e46ad"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Visualization blows up when invalid color is passed mbondyra/kibana
2 participants
@mbondyra @elasticmachine