Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Firefox UI Functional Tests - Visualize.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series basics Dark mode viz should have light class when background color is white #182136

Closed
kibanamachine opened this issue Apr 30, 2024 · 3 comments · Fixed by #190658
Closed

Failing test: Firefox UI Functional Tests - Visualize.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series basics Dark mode viz should have light class when background color is white #182136

kibanamachine opened this issue Apr 30, 2024 · 3 comments · Fixed by #190658
Assignees
@mbondyra
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 30, 2024 •
edited
Loading

A test failed on a tracked branch

Error: expected false to equal true
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at Context.<anonymous> (_tsvb_time_series.ts:159:69)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Apr 30, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 30, 2024
@kibanamachine kibanamachine added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Apr 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 30, 2024
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue May 1, 2024
@mistic
skip flaky suite (#182136)
639938c
@mistic
Copy link
Member

mistic commented May 1, 2024

Skipped.

main: 639938c

@mbondyra mbondyra assigned mbondyra and unassigned nickofthyme Aug 15, 2024
@mbondyra mbondyra mentioned this issue Aug 16, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 19, 2024
@mbondyra
[TSVB] Visualization blows up when invalid color is passed (elastic#1…
50748c8 
…90658)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784

## Summary

Fixes elastic#190657
Fixes elastic#182136

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit f8e873f)
kibanamachine referenced this issue Aug 19, 2024
@kibanamachine @mbondyra
[8.15] [TSVB] Visualization blows up when invalid color is passed (#1…
f726e59 
…90658) (#190693)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[TSVB] Visualization blows up when invalid color is passed
(#190658)](#190658)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-08-19T12:27:06Z","message":"[TSVB]
Visualization blows up when invalid color is passed
(#190658)\n\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784\r\n\r\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190657\r\nFixes
https://github.com/elastic/kibana/issues/182136\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f8e873f87d15014a6f5364482e72ef3ff67e46ad","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","release_note:fix","Team:Visualizations","backport:prev-minor","v8.16.0"],"title":"[TSVB]
Visualization blows up when invalid color is
passed","number":190658,"url":"https://github.com/elastic/kibana/pull/190658","mergeCommit":{"message":"[TSVB]
Visualization blows up when invalid color is passed
(#190658)\n\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784\r\n\r\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190657\r\nFixes
https://github.com/elastic/kibana/issues/182136\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f8e873f87d15014a6f5364482e72ef3ff67e46ad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/190658","number":190658,"mergeCommit":{"message":"[TSVB]
Visualization blows up when invalid color is passed
(#190658)\n\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6784\r\n\r\n##
Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/190657\r\nFixes
https://github.com/elastic/kibana/issues/182136\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"f8e873f87d15014a6f5364482e72ef3ff67e46ad"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Visualization blows up when invalid color is passed mbondyra/kibana
5 participants
@mbondyra @mistic @elasticmachine @nickofthyme @kibanamachine