Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] - Auto-complete adds $0 after = #179978

Closed
ninoslavmiskovic opened this issue Apr 3, 2024 · 2 comments · Fixed by #180203
Closed

[ES|QL] - Auto-complete adds $0 after = #179978

ninoslavmiskovic opened this issue Apr 3, 2024 · 2 comments · Fixed by #180203
Assignees
@drewdaemon
Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@ninoslavmiskovic
Copy link
Contributor

Kibana version: 8.14

When I type e.g. this ES|QL query, then after typing "=" then the "$0" is getting added, and that is not the purpose:

from kibana_sample_data_logs |
stats nino =

chrome-capture-2024-4-3

Skaermoptagelse.2024-04-03.kl.16.33.03.mov
@ninoslavmiskovic ninoslavmiskovic added bug Fixes for quality problems that affect the customer experience Team:ESQL ES|QL related features in Kibana labels Apr 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@ninoslavmiskovic ninoslavmiskovic changed the title Auto-complete adds $0 after = [ES|QL] - Auto-complete adds $0 after = Apr 3, 2024
@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana labels Apr 3, 2024
@drewdaemon drewdaemon self-assigned this Apr 5, 2024
@drewdaemon
Copy link
Contributor

The problem is that asSnippet is currently falsey here:

kibana/packages/kbn-monaco/src/esql/lib/converters/suggestions.ts

Line 28 in fb19e57

insertTextRules: asSnippet

Digging deeper.

@drewdaemon drewdaemon mentioned this issue Apr 5, 2024
Merged
1 task
stratoula pushed a commit that referenced this issue Apr 6, 2024
@drewdaemon @kibanamachine
[ES|QL] insert assignment suggestion as a snippet (#180203)
f04153b 
## Summary

Fix #179978

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
@drewdaemon drewdaemon mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewdaemon drewdaemon

Labels
bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] insert assignment suggestion as a snippet drewdaemon/kibana
4 participants
@drewdaemon @elasticmachine @stratoula @ninoslavmiskovic