Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] add higher-level tests for the editor #180502

Open
Tracked by #181185
drewdaemon opened this issue Apr 10, 2024 · 2 comments
Open
Tracked by #181185

[ES|QL] add higher-level tests for the editor #180502

drewdaemon opened this issue Apr 10, 2024 · 2 comments
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture

Comments

@drewdaemon
Copy link
Contributor

One of our key priorities should be the stability of the features we're adding to the ES|QL editor. Right now, we have no in-browser coverage. We should change this.

It could look like a functional test in Discover, or it could be some sort of storybook or example plugin.

The test itself should be stable and should catch bugs like #180489

We could also look at how far we can push RTL with Monaco.
@drewdaemon drewdaemon added technical debt Improvement of the software architecture and operational architecture impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:ESQL ES|QL related features in Kibana labels Apr 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Apr 11, 2024
@drewdaemon drewdaemon mentioned this issue Apr 18, 2024
Open
7 tasks
@drewdaemon
Copy link
Contributor Author

+1 this kind of test suite could have prevented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drewdaemon @elasticmachine @stratoula