Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedFieldList] Improve search for fieldnames by handling spaces like wildcards #165821

Closed
kertal opened this issue Sep 6, 2023 · 1 comment · Fixed by #168381
Closed

[UnifiedFieldList] Improve search for fieldnames by handling spaces like wildcards #165821

kertal opened this issue Sep 6, 2023 · 1 comment · Fixed by #168381
Assignees
@jughosta
Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort papercut Small "burr" in the product that we should fix. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability

Comments

@kertal
Copy link
Member

kertal commented Sep 6, 2023

Describe the feature:
When users enter spaces in the field search on the UnifiedFieldList in Discover & Lens, those should be handled like wildcards. This would make the search for fields when entering e.g. container mem successful, so long field name paths like container.ftw.memory could be found in a quicker way. Currently no matching field would be found.

Describe a specific use case for the feature:
Search for geo returns results:
Bildschirmfoto 2023-09-06 um 12 22 55

Search for geo name doesn't
Bildschirmfoto 2023-09-06 um 12 23 45
This search should return geo.city_name, geo.contintent_name, geo.region_name
@kertal kertal added loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Sep 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added papercut Small "burr" in the product that we should fix. usability labels Sep 6, 2023
@kertal kertal assigned kertal and jughosta and unassigned kertal Sep 28, 2023
@jughosta jughosta mentioned this issue Oct 9, 2023
Merged
2 tasks
jughosta added a commit that referenced this issue Oct 11, 2023
@jughosta @kibanamachine
[UnifiedFieldList] Improve search for fieldnames by handling spaces l…
e0dd4d1 
…ike wildcards (#168381)

- Closes #165821
- Extends the wilcard logic from
#155540

## Summary

This PR allows to flexibly search in the fields sidebar with terms
containing spaces.

<img width="329" alt="Screenshot 2023-10-09 at 18 28 00"
src="https://github.com/elastic/kibana/assets/1415710/67cbcee8-f6fd-4067-8340-42bec7fd5ec7">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <[email protected]>
dej611 pushed a commit to dej611/kibana that referenced this issue Oct 17, 2023
@jughosta @kibanamachine @dej611
[UnifiedFieldList] Improve search for fieldnames by handling spaces l…
e963d25 
…ike wildcards (elastic#168381)

- Closes elastic#165821
- Extends the wilcard logic from
elastic#155540

## Summary

This PR allows to flexibly search in the fields sidebar with terms
containing spaces.

<img width="329" alt="Screenshot 2023-10-09 at 18 28 00"
src="https://github.com/elastic/kibana/assets/1415710/67cbcee8-f6fd-4067-8340-42bec7fd5ec7">



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort papercut Small "burr" in the product that we should fix. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UnifiedFieldList] Improve search for fieldnames by handling spaces like wildcards jughosta/kibana
3 participants
@kertal @jughosta @elasticmachine