Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Support responsive view for the field list #147884

Closed
Tracked by #137779
jughosta opened this issue Dec 20, 2022 · 1 comment · Fixed by #160397
Closed
Tracked by #137779

[UnifiedFieldList] Support responsive view for the field list #147884

jughosta opened this issue Dec 20, 2022 · 1 comment · Fixed by #160397
Assignees
Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@jughosta
Copy link
Contributor

jughosta commented Dec 20, 2022

Part of #137779

As currently in Discover:

  • a full list for desktop view
  • a button + the list in a flyout for mobile view

Desktop (already supported by UnifiedFieldList):
Screenshot 2022-12-20 at 18 57 05

Mobile view (this what needs to be added to UnifiedFieldList)
Screenshot 2022-12-20 at 18 57 17
Screenshot 2022-12-20 at 18 57 25

Changes to Lens page would need to be aligned with #134377

@jughosta jughosta added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Dec 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 2, 2023
jughosta added a commit that referenced this issue Jul 10, 2023
…uilding block (#160397)

- Closes #145162 
- Closes #147884

## Summary

This PR creates a wrapper/container component (building block) for
unified field list subcomponents:

https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/packages/kbn-unified-field-list/README.md#L5

Available customization options are listed here:
https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/packages/kbn-unified-field-list/src/types.ts#L116

It's now integrated [into
Discover](https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar_responsive.tsx#L373)
and [into example
plugin](https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/examples/unified_field_list_examples/public/field_list_sidebar.tsx#L84).
Usage of unified field list subcomponents and hooks stays unchanged in
Lens plugin as it requires more complex customization (for example Lens
uses IndexPattern/IndexPatternField types instead of data view types).

Also this PR allows to disable multifields grouping and select a variant
(responsive, list only, button only) via
`UnifiedFieldListSidebarContainer` properties.

There should no visual changes on Discover and Lens pages. Unified Field
List Examples plugin will get the same sidebar UI as it's on Discover.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants