Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Fieldlist] Create high level FieldList Wrapper component #145162

Closed
kertal opened this issue Nov 14, 2022 · 1 comment · Fixed by #160397
Closed

[Unified Fieldlist] Create high level FieldList Wrapper component #145162

kertal opened this issue Nov 14, 2022 · 1 comment · Fixed by #160397
Assignees
@jughosta
Labels
chore Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Nov 14, 2022 •
edited
Loading

Placeholder issue to create and integrate the UnifieldFieldList component in Discover.
@kertal kertal added chore Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Nov 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:large Large Level of Effort labels Nov 14, 2022
@kertal kertal changed the title [Unified Fieldlist] Extract UnifiedFieldList component from Lens [Unified Fieldlist] Create UnifiedFieldList component and integrate it in Lens Nov 15, 2022
@kertal kertal changed the title [Unified Fieldlist] Create UnifiedFieldList component and integrate it in Lens [Unified Fieldlist] Create UnifiedFieldList component and integrate it in Discover Nov 16, 2022
@kertal kertal mentioned this issue Nov 18, 2022
Closed
31 tasks
@jughosta jughosta mentioned this issue Jan 31, 2023
Closed
@kertal kertal changed the title [Unified Fieldlist] Create UnifiedFieldList component and integrate it in Discover [Unified Fieldlist] Create high level FieldList Wrapper component Feb 2, 2023
@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 2, 2023
@jughosta jughosta mentioned this issue Jun 9, 2023
Closed
9 tasks
@jughosta jughosta mentioned this issue Jun 23, 2023
Merged
4 tasks
jughosta added a commit that referenced this issue Jul 10, 2023
@jughosta @kibanamachine
@davismcphee @stratoula
[UnifiedFieldList][Discover] Create a high level unified field list b…
ea53763 
…uilding block (#160397)

- Closes #145162 
- Closes #147884

## Summary

This PR creates a wrapper/container component (building block) for
unified field list subcomponents:

https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/packages/kbn-unified-field-list/README.md#L5

Available customization options are listed here:
https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/packages/kbn-unified-field-list/src/types.ts#L116

It's now integrated [into
Discover](https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/src/plugins/discover/public/application/main/components/sidebar/discover_sidebar_responsive.tsx#L373)
and [into example
plugin](https://github.com/elastic/kibana/blob/93acc6f7070786879b9e4821d21bcd1a9dbaa403/examples/unified_field_list_examples/public/field_list_sidebar.tsx#L84).
Usage of unified field list subcomponents and hooks stays unchanged in
Lens plugin as it requires more complex customization (for example Lens
uses IndexPattern/IndexPatternField types instead of data view types).

Also this PR allows to disable multifields grouping and select a variant
(responsive, list only, button only) via
`UnifiedFieldListSidebarContainer` properties.

There should no visual changes on Discover and Lens pages. Unified Field
List Examples plugin will get the same sidebar UI as it's on Discover.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
chore Feature:UnifiedFieldList The unified field list component used by Lens & Discover impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UnifiedFieldList][Discover] Create a high level unified field list building block jughosta/kibana
3 participants
@kertal @jughosta @elasticmachine