Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Params support for lightweight monitors #147467

Closed
andrewvc opened this issue Dec 6, 2022 · 7 comments · Fixed by #148634
Closed

[Uptime] Params support for lightweight monitors #147467

andrewvc opened this issue Dec 6, 2022 · 7 comments · Fixed by #148634
Assignees
@shahzad31
Labels
enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Dec 6, 2022 •
edited by paulb-elastic
Loading

Lightweight pushed monitors should support params using the same ${variable} syntax beats supports. For example:

- type: http
  name: Admin Check
  url: ...
  username: ${admin_user:admin}
  password: ${admin_password}

See the beats docs for the full spec for how beats does this.

The PR includes the ability to set this in the UI as well as for Project Monitors
@andrewvc andrewvc added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:Uptime)

@shahzad31
Copy link
Contributor

i am wondering if we should do this in kibana instead of heartbeat.

@shahzad31 shahzad31 mentioned this issue Dec 12, 2022
Closed
3 tasks
@paulb-elastic
Copy link
Contributor

We should spike this initially to determne the effort needed (cc @emilioalvap)

@shahzad31
Copy link
Contributor

I think this should be done on kibana side in my opinion. We have params available in kibana so we can just replace keys with values in kibana before sending them to heartbeat.

@paulb-elastic
Copy link
Contributor

Removed params as being defined per monitor (we don't to that for browser monitors)

@paulb-elastic paulb-elastic transferred this issue from elastic/beats Dec 13, 2022
@paulb-elastic
Copy link
Contributor

Discussed and this will be done in Kibana

@paulb-elastic paulb-elastic changed the title [Heartbeat] Params support [Uptime] Params support Dec 13, 2022
@shahzad31 shahzad31 changed the title [Uptime] Params support [Uptime] Params support for lightweight monitors Dec 16, 2022
@shahzad31 shahzad31 self-assigned this Jan 10, 2023
@shahzad31 shahzad31 mentioned this issue Jan 10, 2023
Merged
@paulb-elastic paulb-elastic mentioned this issue Feb 8, 2023
Closed
@paulb-elastic paulb-elastic mentioned this issue Mar 1, 2023
Merged
shahzad31 added a commit that referenced this issue Mar 28, 2023
@shahzad31 @kibanamachine @dominiqueclarke
[Synthetics] Add lightweight params support (#148634)
378c5c1 
## Summary

Fixes #147467


Users will be able to specify params in following format in project
monitors or UI


```
- type: http
  name: Admin Check
  url: ...
  username: ${admin_user:admin}
  password: ${admin_password}
```

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Dominique Clarke <[email protected]>
This was referenced Mar 29, 2023
Closed
Closed
@shahzad31
Copy link
Contributor

POST FF Testing looks good !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics] Add lightweight params support shahzad31/kibana
4 participants
@andrewvc @shahzad31 @elasticmachine @paulb-elastic