Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests: src/plugins/dashboard/public/application/embeddable #126000

Closed
jbudz opened this issue Feb 17, 2022 · 0 comments · Fixed by #149648
Closed

Failing tests: src/plugins/dashboard/public/application/embeddable #126000

jbudz opened this issue Feb 17, 2022 · 0 comments · Fixed by #149648
Assignees
@nreese
Labels
skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.17.1

Comments

@jbudz
Copy link
Member

jbudz commented Feb 17, 2022

As part of the #98650, unhandled promise rejections now cause the process to exit. The following test suites were disabled to move forward with the upgrade.

node scripts/jest

  • src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.test.tsx
  • src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.test.tsx
@jbudz jbudz added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas skipped-test v7.17.1 labels Feb 17, 2022
@jbudz jbudz mentioned this issue Feb 17, 2022
Closed
23 tasks
@nreese nreese mentioned this issue Jan 26, 2023
Merged
@nreese nreese self-assigned this Jan 27, 2023
nreese added a commit that referenced this issue Jan 30, 2023
@nreese @kibanamachine
unskip jest tests due to unhandled promise rejections (#149648)
0a31dda 
Fixes #126000

Unskip tests in
/Users/nreese/projects/kibana/src/plugins/dashboard/public/dashboard_container/component/grid/dashboard_grid.test.tsx

viewport/dashboard_viewport.test.tsx removed in
#144332.

---------

Co-authored-by: kibanamachine <[email protected]>
This was referenced Jan 30, 2023
Closed
Closed
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
@nreese @kibanamachine @kqualters-elastic
unskip jest tests due to unhandled promise rejections (elastic#149648)
9d1bf84 
Fixes elastic#126000

Unskip tests in
/Users/nreese/projects/kibana/src/plugins/dashboard/public/dashboard_container/component/grid/dashboard_grid.test.tsx

viewport/dashboard_viewport.test.tsx removed in
elastic#144332.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
skipped-test Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.17.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unskip jest tests due to unhandled promise rejections nreese/kibana
2 participants
@nreese @jbudz