Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Tech Debt] Unskip Dashboard Grid Unit Tests #147489

Closed
ThomThomson opened this issue Dec 14, 2022 · 2 comments
Closed

[Dashboard] [Tech Debt] Unskip Dashboard Grid Unit Tests #147489

ThomThomson opened this issue Dec 14, 2022 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

The Dashboard Grid unit tests at src/plugins/dashboard/public/dashboard_container/component/grid/dashboard_grid.test.tsx were originally skipped as part of an upgrade to Node 16. This has slipped through the cracks and needs to be fixed.

They have been skipped for long enough now that changes have built up to cause failures. We should adjust these, fix the failures, and make sure that there are no longer unhandled promise rejections in these tests.
@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Dec 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson mentioned this issue Dec 14, 2022
Merged
@ThomThomson ThomThomson mentioned this issue Jan 30, 2023
Merged
@nreese
Copy link
Contributor

nreese commented Jan 30, 2023 •
edited
Loading

Closed duplicate of #126000

@nreese nreese closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @ThomThomson @elasticmachine