[8.15] [Index management] Fix passthrough field bug (#193246) (#194187)

# Backport This will backport the following commits from `main` to `8.15`: - [[Index management] Fix passthrough field bug (#193246)](#193246)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Ignacio Rivas <[email protected]>
elastic · Sep 26, 2024 · badcb6e · badcb6e
1 parent 9e0bc9f
commit badcb6e
Show file tree

Hide file tree

Showing 6 changed files with 79 additions and 9 deletions.
diff --git a/...components/mappings_editor/components/document_fields/field_parameters/type_parameter.tsx b/...components/mappings_editor/components/document_fields/field_parameters/type_parameter.tsx
@@ -6,7 +6,7 @@
  */
 
 import React, { useMemo } from 'react';
-import { EuiFormRow, EuiComboBox, EuiText, EuiLink } from '@elastic/eui';
+import { EuiFormRow, EuiComboBox, EuiText, EuiLink, EuiSpacer } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
 import { documentationService } from '../../../../../services/documentation';
@@ -79,7 +79,9 @@ export const TypeParameter = ({
                     )}
                   </EuiLink>
                 </EuiText>
-              ) : null
+              ) : (
+                <EuiSpacer size="m" />
+              )
             }
           >
             <EuiComboBox

diff --git a/...ication/components/mappings_editor/components/document_fields/fields/field_types/index.ts b/...ication/components/mappings_editor/components/document_fields/fields/field_types/index.ts
@@ -32,6 +32,7 @@ import { OtherType } from './other_type';
 import { NestedType } from './nested_type';
 import { JoinType } from './join_type';
 import { HistogramType } from './histogram_type';
+import { PassthroughType } from './passthrough_type';
 import { ConstantKeywordType } from './constant_keyword_type';
 import { RankFeatureType } from './rank_feature_type';
 import { WildcardType } from './wildcard_type';
@@ -62,6 +63,7 @@ const typeToParametersFormMap: { [key in DataType]?: ComponentType<any> } = {
   nested: NestedType,
   join: JoinType,
   histogram: HistogramType,
+  passthrough: PassthroughType,
   constant_keyword: ConstantKeywordType,
   rank_feature: RankFeatureType,
   wildcard: WildcardType,

diff --git a/...onents/mappings_editor/components/document_fields/fields/field_types/passthrough_type.tsx b/...onents/mappings_editor/components/document_fields/fields/field_types/passthrough_type.tsx
@@ -0,0 +1,25 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import React from 'react';
+
+import { UseField, Field, CheckBoxField } from '../../../../shared_imports';
+import { getFieldConfig } from '../../../../lib';
+import { BasicParametersSection } from '../edit_field';
+
+export const PassthroughType = () => {
+  return (
+    <BasicParametersSection>
+      <UseField path="priority" config={getFieldConfig('priority')} component={Field} />
+      <UseField
+        path="dynamic"
+        config={getFieldConfig('dynamic_passthrough')}
+        component={CheckBoxField}
+      />
+    </BasicParametersSection>
+  );
+};
diff --git a/...agement/public/application/components/mappings_editor/constants/data_types_definition.tsx b/...agement/public/application/components/mappings_editor/constants/data_types_definition.tsx
@@ -567,6 +567,12 @@ export const TYPE_DEFINITION: { [key in DataType]: DataTypeDefinition } = {
       </p>
     ),
   },
+  passthrough: {
+    label: i18n.translate('xpack.idxMgmt.mappingsEditor.dataType.passthroughDescription', {
+      defaultMessage: 'Passthrough',
+    }),
+    value: 'passthrough',
+  },
   dense_vector: {
     label: i18n.translate('xpack.idxMgmt.mappingsEditor.dataType.denseVectorDescription', {
       defaultMessage: 'Dense vector',
@@ -998,7 +1004,6 @@ export const TYPE_DEFINITION: { [key in DataType]: DataTypeDefinition } = {
     ),
   },
 };
-
 export const MAIN_TYPES: MainType[] = [
   'alias',
   'binary',
@@ -1011,28 +1016,28 @@ export const MAIN_TYPES: MainType[] = [
   'flattened',
   'geo_point',
   'geo_shape',
+  'histogram',
   'ip',
   'join',
   'keyword',
+  'match_only_text',
   'nested',
   'numeric',
-  'match_only_text',
   'object',
+  'other',
   'percolator',
+  'point',
   'range',
   'rank_feature',
   'rank_features',
   'search_as_you_type',
-  'shape',
   'semantic_text',
+  'shape',
   'sparse_vector',
   'text',
   'token_count',
-  'histogram',
-  'wildcard',
-  'point',
   'version',
-  'other',
+  'wildcard',
 ];
 
 export const MAIN_DATA_TYPE_DEFINITION: {

diff --git a/...agement/public/application/components/mappings_editor/constants/parameters_definition.tsx b/...agement/public/application/components/mappings_editor/constants/parameters_definition.tsx
@@ -1067,6 +1067,39 @@ export const PARAMETERS_DEFINITION: { [key in ParameterName]: ParameterDefinitio
     },
     schema: t.string,
   },
+  priority: {
+    fieldConfig: {
+      defaultValue: '',
+      type: FIELD_TYPES.NUMBER,
+      label: i18n.translate('xpack.idxMgmt.mappingsEditor.priorityFieldLabel', {
+        defaultMessage: 'Priority',
+      }),
+      formatters: [toInt],
+      validations: [
+        {
+          validator: emptyField(
+            i18n.translate(
+              'xpack.idxMgmt.mappingsEditor.parameters.validations.priorityIsRequiredErrorMessage',
+              {
+                defaultMessage: 'Specify a priority.',
+              }
+            )
+          ),
+        },
+      ],
+    },
+    schema: t.string,
+  },
+  dynamic_passthrough: {
+    fieldConfig: {
+      defaultValue: false,
+      type: FIELD_TYPES.CHECKBOX,
+      label: i18n.translate('xpack.idxMgmt.mappingsEditor.dynamicFieldLabel', {
+        defaultMessage: 'Dynamic',
+      }),
+    },
+    schema: t.boolean,
+  },
   reference_field: {
     fieldConfig: {
       defaultValue: '',

diff --git a/...s/index_management/public/application/components/mappings_editor/types/document_fields.ts b/...s/index_management/public/application/components/mappings_editor/types/document_fields.ts
@@ -58,6 +58,7 @@ export type MainType =
   | 'percolator'
   | 'rank_feature'
   | 'rank_features'
+  | 'passthrough'
   | 'shape'
   | 'search_as_you_type'
   | 'sparse_vector'
@@ -158,6 +159,8 @@ export type ParameterName =
   | 'points_only'
   | 'path'
   | 'dims'
+  | 'priority'
+  | 'dynamic_passthrough'
   | 'inference_id'
   | 'reference_field'
   | 'depth_limit'