[Index management] Fix passthrough field bug #193246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
Feature:Index Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
ElenaStoeva
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Thanks for patching this up @sabarasaba! Tested locally and I don't see the error anymore. Changes also lgtm.
One thing I noticed though is that if I change the priority value, the dynamic property gets deleted. Do you think there might be an easy fix for this to add to this PR?
Screen.Recording.2024-09-23.at.19.15.24.mov
|
@elasticmachine merge upstream |
|
Thanks for the review @ElenaStoeva, I've just added another field to take into account the |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
ElenaStoeva
approved these changes
Sep 26, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 99160b6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 99160b6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Index management] Fix passthrough field bug (#193246)](#193246) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T16:26:51Z","message":"[Index management] Fix passthrough field bug (#193246)","sha":"99160b6f9963c3ba9b3065ae89c9042a44b3c3d9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-major","v8.16.0"],"title":"[Index management] Fix passthrough field bug","number":193246,"url":"https://github.com/elastic/kibana/pull/193246","mergeCommit":{"message":"[Index management] Fix passthrough field bug (#193246)","sha":"99160b6f9963c3ba9b3065ae89c9042a44b3c3d9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193246","number":193246,"mergeCommit":{"message":"[Index management] Fix passthrough field bug (#193246)","sha":"99160b6f9963c3ba9b3065ae89c9042a44b3c3d9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[Index management] Fix passthrough field bug (#193246)](#193246) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T16:26:51Z","message":"[Index management] Fix passthrough field bug (#193246)","sha":"99160b6f9963c3ba9b3065ae89c9042a44b3c3d9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-major","v8.16.0"],"title":"[Index management] Fix passthrough field bug","number":193246,"url":"https://github.com/elastic/kibana/pull/193246","mergeCommit":{"message":"[Index management] Fix passthrough field bug (#193246)","sha":"99160b6f9963c3ba9b3065ae89c9042a44b3c3d9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193246","number":193246,"mergeCommit":{"message":"[Index management] Fix passthrough field bug (#193246)","sha":"99160b6f9963c3ba9b3065ae89c9042a44b3c3d9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192125
Summary
This PR adds support for allowing
passthroughfield types in index templates, mainly to prevent breaking the UI. Since this is a hidden experimental feature, the field can only be added to an index template mapping through a console call and not through the UI. And when editing an index template that contains a passthrough field this will be partially editable (only the mandatory fieldprioritycan be changed through the UI) and the rest can be updated through console.