Skip to content

Commit

Permalink
[8.x] Migrate Custom threshold > AVG - PCT - FIRED test to the deploy…
Browse files Browse the repository at this point in the history
…ment agnostic framework (#195902) (#197632)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Migrate Custom threshold > AVG - PCT - FIRED test to the deployment
agnostic framework
(#195902)](#195902)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Maryam
Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T10:22:59Z","message":"Migrate
Custom threshold > AVG - PCT - FIRED test to the deployment agnostic
framework (#195902)\n\nPart of #183378\r\n\r\n## Summary\r\nThis PR
moves the first Custom threshold rule test to the deployment\r\nagnostic
test. The rest will follow in a follow-up PR.\r\n\r\n## How to
run\r\n\r\nTo run serverless\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"Custom Threshold rule\"\r\n```\r\n\r\nTo run
stateful\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"Custom Threshold rule\"\r\n```\r\n\r\n### TODO\r\n\r\n- [x]
https://github.com/elastic/kibana/pull/195890\r\n- [x] Test in MKI
before merging\r\n\r\n\r\n#### How to run tests on MKI\r\n\r\nAccording
to
this\r\n[discussion](https://github.com/elastic/observability-dev/issues/3519#issuecomment-2379914274),\r\nwe
should test in MKI environment before merging. For details on how
to\r\nrun in MKI, see [this section of
the\r\ndocument](https://docs.google.com/document/d/1tiax7xoDYwFXYZjRTgVKkVMjN-SQzBWk4yn1JY6Z5UY/edit#heading=h.ece2z8p74izh)\r\nand
[this\r\nreadme](https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki).","sha":"30f81ce4e932622e4d284b1e6af8c015c22836f5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:build-serverless-image","Team:obs-ux-management"],"number":195902,"url":"https://github.com/elastic/kibana/pull/195902","mergeCommit":{"message":"Migrate
Custom threshold > AVG - PCT - FIRED test to the deployment agnostic
framework (#195902)\n\nPart of #183378\r\n\r\n## Summary\r\nThis PR
moves the first Custom threshold rule test to the deployment\r\nagnostic
test. The rest will follow in a follow-up PR.\r\n\r\n## How to
run\r\n\r\nTo run serverless\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"Custom Threshold rule\"\r\n```\r\n\r\nTo run
stateful\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"Custom Threshold rule\"\r\n```\r\n\r\n### TODO\r\n\r\n- [x]
https://github.com/elastic/kibana/pull/195890\r\n- [x] Test in MKI
before merging\r\n\r\n\r\n#### How to run tests on MKI\r\n\r\nAccording
to
this\r\n[discussion](https://github.com/elastic/observability-dev/issues/3519#issuecomment-2379914274),\r\nwe
should test in MKI environment before merging. For details on how
to\r\nrun in MKI, see [this section of
the\r\ndocument](https://docs.google.com/document/d/1tiax7xoDYwFXYZjRTgVKkVMjN-SQzBWk4yn1JY6Z5UY/edit#heading=h.ece2z8p74izh)\r\nand
[this\r\nreadme](https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki).","sha":"30f81ce4e932622e4d284b1e6af8c015c22836f5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195902","number":195902,"mergeCommit":{"message":"Migrate
Custom threshold > AVG - PCT - FIRED test to the deployment agnostic
framework (#195902)\n\nPart of #183378\r\n\r\n## Summary\r\nThis PR
moves the first Custom threshold rule test to the deployment\r\nagnostic
test. The rest will follow in a follow-up PR.\r\n\r\n## How to
run\r\n\r\nTo run serverless\r\n```\r\nnode
scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
--grep=\"Custom Threshold rule\"\r\n```\r\n\r\nTo run
stateful\r\n```\r\nnode scripts/functional_tests_server --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode
scripts/functional_test_runner --config
x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
--grep=\"Custom Threshold rule\"\r\n```\r\n\r\n### TODO\r\n\r\n- [x]
https://github.com/elastic/kibana/pull/195890\r\n- [x] Test in MKI
before merging\r\n\r\n\r\n#### How to run tests on MKI\r\n\r\nAccording
to
this\r\n[discussion](https://github.com/elastic/observability-dev/issues/3519#issuecomment-2379914274),\r\nwe
should test in MKI environment before merging. For details on how
to\r\nrun in MKI, see [this section of
the\r\ndocument](https://docs.google.com/document/d/1tiax7xoDYwFXYZjRTgVKkVMjN-SQzBWk4yn1JY6Z5UY/edit#heading=h.ece2z8p74izh)\r\nand
[this\r\nreadme](https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki).","sha":"30f81ce4e932622e4d284b1e6af8c015c22836f5"}}]}]
BACKPORT-->
  • Loading branch information
maryam-saeidi authored Oct 25, 2024
1 parent ac48c81 commit 733ebec
Show file tree
Hide file tree
Showing 9 changed files with 78 additions and 293 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export default function ({ loadTestFile }: any) {
describe('Observability Rules', () => {
describe('Rules Endpoints', () => {
loadTestFile(require.resolve('./metric_threshold_rule'));
loadTestFile(require.resolve('./custom_threshold_rule/avg_pct_fired'));
loadTestFile(require.resolve('./custom_threshold_rule/p99_pct_fired'));
loadTestFile(require.resolve('./custom_threshold_rule/rate_bytes_fired'));
loadTestFile(require.resolve('./custom_threshold_rule/avg_pct_no_data'));
Expand Down
Loading

0 comments on commit 733ebec

Please sign in to comment.