[Search][Serverless] Enabled Onboarding without Feature Flag (#196755)

## Summary This PR removes the feature flag check for the new search onboarding experience in Serverless. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit e955cb0) # Conflicts: # x-pack/plugins/serverless_search/public/navigation_tree.ts # x-pack/test_serverless/functional/test_suites/search/index.ts # x-pack/test_serverless/functional/test_suites/search/navigation.ts
elastic · Oct 18, 2024 · 68796f1 · 68796f1
1 parent ed3a8de
commit 68796f1
Show file tree

Hide file tree

Showing 14 changed files with 282 additions and 97 deletions.
diff --git a/x-pack/plugins/search_indices/common/index.ts b/x-pack/plugins/search_indices/common/index.ts
@@ -12,6 +12,4 @@ export const PLUGIN_NAME = 'searchIndices';
 export const START_APP_ID: SearchStart = 'elasticsearchStart';
 export const INDICES_APP_ID: SearchIndices = 'elasticsearchIndices';
 
-export const GLOBAL_EMPTY_STATE_FEATURE_FLAG_ID = 'searchIndices:globalEmptyStateEnabled';
-
 export type { IndicesStatusResponse, UserStartPrivilegesResponse } from './types';
diff --git a/x-pack/plugins/search_indices/public/feature_flags.ts b/x-pack/plugins/search_indices/public/feature_flags.ts
diff --git a/x-pack/plugins/search_indices/public/plugin.ts b/x-pack/plugins/search_indices/public/plugin.ts
@@ -18,7 +18,6 @@ import type {
 import { initQueryClient } from './services/query_client';
 import { INDICES_APP_ID, START_APP_ID } from '../common';
 import { INDICES_APP_BASE, START_APP_BASE } from './routes';
-import { isGlobalEmptyStateEnabled } from './feature_flags';
 
 export class SearchIndicesPlugin
   implements Plugin<SearchIndicesPluginSetup, SearchIndicesPluginStart>
@@ -28,13 +27,6 @@ export class SearchIndicesPlugin
   public setup(
     core: CoreSetup<SearchIndicesAppPluginStartDependencies, SearchIndicesPluginStart>
   ): SearchIndicesPluginSetup {
-    if (!isGlobalEmptyStateEnabled(core.uiSettings)) {
-      return {
-        enabled: this.pluginEnabled,
-        startAppId: START_APP_ID,
-        startRoute: START_APP_BASE,
-      };
-    }
     this.pluginEnabled = true;
 
     const queryClient = initQueryClient(core.notifications.toasts);

diff --git a/x-pack/plugins/serverless_search/kibana.jsonc b/x-pack/plugins/serverless_search/kibana.jsonc
@@ -16,6 +16,7 @@
       "devTools",
       "discover",
       "management",
+      "searchIndices",
       "searchprofiler",
       "security",
       "serverless",
@@ -25,7 +26,6 @@
     "optionalPlugins": [
       "indexManagement",
       "searchConnectors",
-      "searchIndices",
       "searchInferenceEndpoints",
       "usageCollection"
     ],

diff --git a/x-pack/plugins/serverless_search/public/navigation_tree.ts b/x-pack/plugins/serverless_search/public/navigation_tree.ts
@@ -5,27 +5,11 @@
  * 2.0.
  */
 
-import type {
-  AppDeepLinkId,
-  NavigationTreeDefinition,
-  NodeDefinition,
-} from '@kbn/core-chrome-browser';
+import type { NavigationTreeDefinition } from '@kbn/core-chrome-browser';
 import { i18n } from '@kbn/i18n';
 import { CONNECTORS_LABEL } from '../common/i18n_string';
 
-const gettingStartedItem: NodeDefinition<AppDeepLinkId, string, string> = {
-  id: 'gettingStarted',
-  title: i18n.translate('xpack.serverlessSearch.nav.gettingStarted', {
-    defaultMessage: 'Getting Started',
-  }),
-  link: 'serverlessElasticsearch',
-  spaceBefore: 'm',
-};
-
-export const navigationTree = (
-  homeLink: AppDeepLinkId = 'serverlessElasticsearch' as AppDeepLinkId,
-  showGettingStarted: boolean
-): NavigationTreeDefinition => ({
+export const navigationTree = (): NavigationTreeDefinition => ({
   body: [
     {
       type: 'navGroup',
@@ -41,7 +25,7 @@ export const navigationTree = (
           title: i18n.translate('xpack.serverlessSearch.nav.home', {
             defaultMessage: 'Home',
           }),
-          link: homeLink,
+          link: 'elasticsearchStart',
           spaceBefore: 'm',
         },
         {
@@ -138,7 +122,40 @@ export const navigationTree = (
             },
           ],
         },
-        ...(showGettingStarted ? [gettingStartedItem] : []),
+        {
+          id: 'analyze',
+          title: i18n.translate('xpack.serverlessSearch.nav.analyze', {
+            defaultMessage: 'Analyze',
+          }),
+          spaceBefore: 'm',
+          children: [
+            {
+              link: 'discover',
+            },
+            {
+              link: 'dashboards',
+              getIsActive: ({ pathNameSerialized, prepend }) => {
+                return pathNameSerialized.startsWith(prepend('/app/dashboards'));
+              },
+            },
+          ],
+        },
+        {
+          id: 'otherTools',
+          title: i18n.translate('xpack.serverlessSearch.nav.otherTools', {
+            defaultMessage: 'Other tools',
+          }),
+          spaceBefore: 'm',
+          children: [{ link: 'maps' }],
+        },
+        {
+          id: 'gettingStarted',
+          title: i18n.translate('xpack.serverlessSearch.nav.gettingStarted', {
+            defaultMessage: 'Getting Started',
+          }),
+          link: 'serverlessElasticsearch',
+          spaceBefore: 'm',
+        },
       ],
     },
   ],

diff --git a/x-pack/plugins/serverless_search/public/plugin.ts b/x-pack/plugins/serverless_search/public/plugin.ts
@@ -73,10 +73,6 @@ export class ServerlessSearchPlugin
     const homeTitle = i18n.translate('xpack.serverlessSearch.app.home.title', {
       defaultMessage: 'Home',
     });
-    const useGlobalEmptyState = setupDeps.searchIndices?.enabled ?? false;
-    const serverlessElasticsearchAppRoute = useGlobalEmptyState
-      ? '/app/elasticsearch/getting_started'
-      : '/app/elasticsearch';
 
     core.application.register({
       id: 'serverlessElasticsearch',
@@ -85,7 +81,7 @@ export class ServerlessSearchPlugin
       }),
       euiIconType: 'logoElastic',
       category: DEFAULT_APP_CATEGORIES.enterpriseSearch,
-      appRoute: serverlessElasticsearchAppRoute,
+      appRoute: '/app/elasticsearch/getting_started',
       async mount({ element, history }: AppMountParameters) {
         const { renderApp } = await import('./application/elasticsearch');
         const [coreStart, services] = await core.getStartServices();
@@ -124,23 +120,21 @@ export class ServerlessSearchPlugin
       },
     });
 
-    if (useGlobalEmptyState) {
-      const redirectApp = setupDeps.searchIndices!.startAppId;
-      core.application.register({
-        id: 'serverlessHomeRedirect',
-        title: homeTitle,
-        appRoute: '/app/elasticsearch',
-        euiIconType: 'logoElastic',
-        category: DEFAULT_APP_CATEGORIES.enterpriseSearch,
-        visibleIn: [],
-        async mount({}: AppMountParameters) {
-          const [coreStart] = await core.getStartServices();
-          coreStart.chrome.docTitle.change(homeTitle);
-          coreStart.application.navigateToApp(redirectApp);
-          return () => {};
-        },
-      });
-    }
+    const { searchIndices } = setupDeps;
+    core.application.register({
+      id: 'serverlessHomeRedirect',
+      title: homeTitle,
+      appRoute: '/app/elasticsearch',
+      euiIconType: 'logoElastic',
+      category: DEFAULT_APP_CATEGORIES.enterpriseSearch,
+      visibleIn: [],
+      async mount({}: AppMountParameters) {
+        const [coreStart] = await core.getStartServices();
+        coreStart.chrome.docTitle.change(homeTitle);
+        coreStart.application.navigateToApp(searchIndices.startAppId);
+        return () => {};
+      },
+    });
 
     setupDeps.discover.showInlineTopNav();
 
@@ -152,18 +146,9 @@ export class ServerlessSearchPlugin
     services: ServerlessSearchPluginStartDependencies
   ): ServerlessSearchPluginStart {
     const { serverless, management, indexManagement, security } = services;
-    const useGlobalEmptyState = services.searchIndices?.enabled ?? false;
-    const homeRoute = useGlobalEmptyState
-      ? services.searchIndices!.startRoute
-      : '/app/elasticsearch';
-    serverless.setProjectHome(homeRoute);
-
-    const navigationTree$ = of(
-      navigationTree(
-        useGlobalEmptyState ? services.searchIndices?.startAppId : undefined,
-        useGlobalEmptyState
-      )
-    );
+    serverless.setProjectHome(services.searchIndices.startRoute);
+
+    const navigationTree$ = of(navigationTree());
     serverless.initNavigation('search', navigationTree$, { dataTestSubj: 'svlSearchSideNav' });
 
     const extendCardNavDefinitions = serverless.getNavigationCards(

diff --git a/x-pack/plugins/serverless_search/public/types.ts b/x-pack/plugins/serverless_search/public/types.ts
@@ -31,7 +31,7 @@ export interface ServerlessSearchPluginSetupDependencies {
   management: ManagementSetup;
   serverless: ServerlessPluginSetup;
   discover: DiscoverSetup;
-  searchIndices?: SearchIndicesPluginSetup;
+  searchIndices: SearchIndicesPluginSetup;
 }
 
 export interface ServerlessSearchPluginStartDependencies {
@@ -44,5 +44,5 @@ export interface ServerlessSearchPluginStartDependencies {
   serverless: ServerlessPluginStart;
   share: SharePluginStart;
   indexManagement?: IndexManagementPluginStart;
-  searchIndices?: SearchIndicesPluginStart;
+  searchIndices: SearchIndicesPluginStart;
 }
diff --git a/x-pack/test_serverless/functional/services/svl_search_navigation.ts b/x-pack/test_serverless/functional/services/svl_search_navigation.ts
@@ -19,7 +19,8 @@ export function SvlSearchNavigationServiceProvider({
     async navigateToLandingPage() {
       await retry.tryForTime(60 * 1000, async () => {
         await PageObjects.common.navigateToApp('landingPage');
-        await testSubjects.existOrFail('svlSearchOverviewPage', { timeout: 2000 });
+        // Wait for the side nav, since the landing page will sometimes redirect to index management now
+        await testSubjects.existOrFail('svlSearchSideNav', { timeout: 2000 });
       });
     },
     async navigateToGettingStartedPage() {

diff --git a/x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts b/x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts
@@ -26,7 +26,6 @@ export default createTestConfig({
     `--xpack.cloud.organization_url=/account/members`,
     `--xpack.security.roleManagementEnabled=true`,
     `--xpack.spaces.maxSpaces=100`, // enables spaces UI capabilities
-    `--uiSettings.overrides.searchIndices:globalEmptyStateEnabled=true`, // global empty state FF
   ],
   // load tests in the index file
   testFiles: [require.resolve('./index.feature_flags.ts')],
@@ -38,6 +37,12 @@ export default createTestConfig({
     serverlessElasticsearch: {
       pathname: '/app/elasticsearch/getting_started',
     },
+    serverlessConnectors: {
+      pathname: '/app/connectors',
+    },
+    searchPlayground: {
+      pathname: '/app/search_playground',
+    },
     elasticsearchStart: {
       pathname: '/app/elasticsearch/start',
     },

diff --git a/x-pack/test_serverless/functional/test_suites/search/config.ts b/x-pack/test_serverless/functional/test_suites/search/config.ts
@@ -26,13 +26,19 @@ export default createTestConfig({
   ],
   apps: {
     serverlessElasticsearch: {
-      pathname: '/app/elasticsearch',
+      pathname: '/app/elasticsearch/getting_started',
     },
     serverlessConnectors: {
       pathname: '/app/connectors',
     },
     searchPlayground: {
       pathname: '/app/search_playground',
     },
+    elasticsearchStart: {
+      pathname: '/app/elasticsearch/start',
+    },
+    elasticsearchIndices: {
+      pathname: '/app/elasticsearch/indices',
+    },
   },
 });
diff --git a/x-pack/test_serverless/functional/test_suites/search/console_notebooks.ts b/x-pack/test_serverless/functional/test_suites/search/console_notebooks.ts
@@ -7,12 +7,15 @@
 
 import { FtrProviderContext } from '../../ftr_provider_context';
 
-export default function ({ getPageObjects }: FtrProviderContext) {
+export default function ({ getPageObjects, getService }: FtrProviderContext) {
   const pageObjects = getPageObjects(['svlCommonPage', 'embeddedConsole']);
+  const svlSearchNavigation = getService('svlSearchNavigation');
 
   describe('Console Notebooks', function () {
     before(async () => {
       await pageObjects.svlCommonPage.loginAsViewer();
+
+      await svlSearchNavigation.navigateToGettingStartedPage();
     });
 
     it('has notebooks view available', async () => {

diff --git a/x-pack/test_serverless/functional/test_suites/search/index.feature_flags.ts b/x-pack/test_serverless/functional/test_suites/search/index.feature_flags.ts
@@ -10,9 +10,7 @@ import { FtrProviderContext } from '../../ftr_provider_context';
 export default function ({ loadTestFile }: FtrProviderContext) {
   describe('serverless search UI - feature flags', function () {
     // add tests that require feature flags, defined in config.feature_flags.ts
-    loadTestFile(require.resolve('./elasticsearch_start.ts'));
-    loadTestFile(require.resolve('./search_index_detail.ts'));
-    loadTestFile(require.resolve('./getting_started'));
+
     loadTestFile(require.resolve('../common/platform_security/navigation/management_nav_cards.ts'));
     loadTestFile(require.resolve('../common/platform_security/roles.ts'));
     loadTestFile(require.resolve('../common/spaces/multiple_spaces_enabled.ts'));

diff --git a/x-pack/test_serverless/functional/test_suites/search/index.ts b/x-pack/test_serverless/functional/test_suites/search/index.ts
@@ -11,10 +11,12 @@ export default function ({ loadTestFile }: FtrProviderContext) {
   describe('serverless search UI', function () {
     this.tags(['esGate']);
 
+    loadTestFile(require.resolve('./navigation'));
+    loadTestFile(require.resolve('./elasticsearch_start.ts'));
+    loadTestFile(require.resolve('./search_index_detail.ts'));
     loadTestFile(require.resolve('./getting_started'));
     loadTestFile(require.resolve('./connectors/connectors_overview'));
     loadTestFile(require.resolve('./default_dataview'));
-    loadTestFile(require.resolve('./navigation'));
     loadTestFile(require.resolve('./pipelines'));
     loadTestFile(require.resolve('./cases/attachment_framework'));
     loadTestFile(require.resolve('./dashboards/build_dashboard'));