[Search][Serverless] Enabled Onboarding without Feature Flag #196755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7170[❌] x-pack/test_serverless/functional/test_suites/search/config.ts: 0/25 tests passed. |
joemcelroy
approved these changes
Oct 17, 2024
Updated navigateToLandingPage to wait on the side nav instead of a page element since the new landing page can conditionally redirect you to index management.
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
|
jloleysens
approved these changes
Oct 18, 2024
dmlemeshko
approved these changes
Oct 18, 2024
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7180[✅] x-pack/test_serverless/functional/test_suites/search/config.ts: 30/30 tests passed. |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11407566665 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
TattdCodeMonkey
added a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Oct 18, 2024
…#196755) ## Summary This PR removes the feature flag check for the new search onboarding experience in Serverless. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed (cherry picked from commit e955cb0) # Conflicts: # x-pack/plugins/serverless_search/public/navigation_tree.ts # x-pack/test_serverless/functional/test_suites/search/index.ts # x-pack/test_serverless/functional/test_suites/search/navigation.ts
TattdCodeMonkey
added a commit
that referenced
this pull request
Oct 20, 2024
…196755) (#196929) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][Serverless] Enabled Onboarding without Feature Flag (#196755)](#196755) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T16:39:21Z","message":"[Search][Serverless] Enabled Onboarding without Feature Flag (#196755)\n\n## Summary\r\n\r\nThis PR removes the feature flag check for the new search onboarding\r\nexperience in Serverless.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"e955cb044fcad83fd9e1c6631eddd95aa7357ad7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"number":196755,"url":"https://github.com/elastic/kibana/pull/196755","mergeCommit":{"message":"[Search][Serverless] Enabled Onboarding without Feature Flag (#196755)\n\n## Summary\r\n\r\nThis PR removes the feature flag check for the new search onboarding\r\nexperience in Serverless.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"e955cb044fcad83fd9e1c6631eddd95aa7357ad7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196755","number":196755,"mergeCommit":{"message":"[Search][Serverless] Enabled Onboarding without Feature Flag (#196755)\n\n## Summary\r\n\r\nThis PR removes the feature flag check for the new search onboarding\r\nexperience in Serverless.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed","sha":"e955cb044fcad83fd9e1c6631eddd95aa7357ad7"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the feature flag check for the new search onboarding experience in Serverless.
Checklist