Skip to content

Commit

Permalink
test: hard code esApiVersion to master (#13198)
Browse files Browse the repository at this point in the history
Until elasticsearch.js actually has support for 6.x/6.0 branches, this
needs to just rely on the master apiVersion.

Also, we shouldn't change this esApiVersion in tests unless we are also
changing the value in our elasticsearch plugin proper, otherwise our
tests can accidentally use a different API version than reality.
  • Loading branch information
epixa committed Jul 28, 2017
1 parent 9ee0ca8 commit 229580e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/core_plugins/tests_bundle/tests_entry_template.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { esTestConfig } from '../../test_utils/es';

export default function ({ env, bundle }) {

const pluginSlug = env.pluginInfo.sort()
Expand Down Expand Up @@ -28,7 +26,7 @@ window.__KBN__ = {
vars: {
kbnIndex: '.kibana',
esShardTimeout: 1500,
esApiVersion: ${JSON.stringify(esTestConfig.getBranch())},
esApiVersion: 'master',
esRequestTimeout: '300000',
tilemapsConfig: {
deprecated: {
Expand Down

0 comments on commit 229580e

Please sign in to comment.