Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memcached]: Address skipped validation SVR00003 #8347

Closed
wants to merge 3 commits into from
Closed

[memcached]: Address skipped validation SVR00003 #8347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bb06c0
[memcached]: Address SVR00003
shmsr Oct 31, 2023
ef0d694
[memcached]: Add changelog
shmsr Oct 31, 2023
82faec0
Update packages/memcached/changelog.yml
shmsr Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/memcached/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.3.1"
changes:
- description: Remove dangling references from the dashboard
type: enhancement
link: https://github.com/elastic/integrations/pull/8347
- version: 1.3.0
changes:
- description: Update the package format_version to 3.0.0.
Expand Down
12 changes: 1 addition & 11 deletions packages/memcached/kibana/dashboard/memcached-a36fa0b0-eccf-11ec-b66b-6bfdc9ecc703.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,17 +1069,7 @@
"id": "metrics-*",
"name": "5061237a-3a71-485a-be3f-5d8e629e579e:indexpattern-datasource-layer-09bed68a-54a8-41fe-8e2f-6937efc350b4",
"type": "index-pattern"
},
{
"id": "memcached-fleet-managed-default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmsr : For my clarity, why do these pointers get created in the first place ?
They become dangling as I suppose the corresponding object gets removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see the *.json, this is under references. References in the dashboard are used to establish relationships between different saved objects or components within Kibana.

Suppose you have 3 different viz that depend on the same index-pattern, so they could reference an index-pattern (e.g., metrics-*) that can be used by all 3 viz. So the id and name will be accordingly and the reference type will be index-pattern.

So this is a case for tags. There's no relationship currently being maintained with this reference.

If you see: #8348 (comment) you'll see some detailed examples of filters and their dependence on references (index-pattern).

"name": "tag-fleet-managed-default",
"type": "tag"
},
{
"id": "memcached-fleet-pkg-memcached-default",
"name": "tag-fleet-pkg-memcached-default",
"type": "tag"
}
],
"type": "dashboard"
}
}
2 changes: 1 addition & 1 deletion packages/memcached/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: memcached
title: Memcached
version: "1.3.0"
version: "1.3.1"
description: Memcached Integration
type: integration
categories:
Expand Down
1 change: 0 additions & 1 deletion packages/memcached/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
errors:
exclude_checks:
- SVR00003
- SVR00002