-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memcached]: Address skipped validation SVR00003 #8347
Conversation
Should it be a bug-fix or an enhancement? Upon further consideration, I think enhancement here would be more apt? |
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1069,17 +1069,7 @@ | |||
"id": "metrics-*", | |||
"name": "5061237a-3a71-485a-be3f-5d8e629e579e:indexpattern-datasource-layer-09bed68a-54a8-41fe-8e2f-6937efc350b4", | |||
"type": "index-pattern" | |||
}, | |||
{ | |||
"id": "memcached-fleet-managed-default", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shmsr : For my clarity, why do these pointers get created in the first place ?
They become dangling as I suppose the corresponding object gets removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you see the *.json, this is under references
. References in the dashboard are used to establish relationships between different saved objects or components within Kibana.
Suppose you have 3 different viz that depend on the same index-pattern, so they could reference an index-pattern (e.g., metrics-*
) that can be used by all 3 viz. So the id
and name
will be accordingly and the reference type
will be index-pattern
.
So this is a case for tags. There's no relationship currently being maintained with this reference.
If you see: #8348 (comment) you'll see some detailed examples of filters and their dependence on references (index-pattern).
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi @shmsr, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks! |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
@devamanv Need you review here as well. |
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
@shmsr : Still valid ? |
I have written a Go program that is based on
ValiadateKibanaNoDanglingObjectIDs
lint frompackage-spec
repository. It uses the same logic to find the dangling references and sets the correct parameters for yq to do in-place changes:Example:
$ yq -i -I4 'del(.references.[] | .. | select(.id == "memcached-fleet-managed-default" and .type == "tag"))' kibana/dashboard/memcached-a36fa0b0-eccf-11ec-b66b-6bfdc9ecc703.json
I'll soon push that program so that other teams can also use the same to remove any dangling object ids. Very easy to use.
Proposed commit message
Address SVR00003 for memcached package i.e., removal of dangling object ids.
This is to address the skipped validation part of the package-spec v3 migration.
Checklist
changelog.yml
file.Author's Checklist
Installs successfully and no obvious breakages in viz.
Related issues
obs-infraobs-integrations
owned packages toformat_version: 3.0.0
#8028