Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memcached]: Address skipped validation SVR00003 #8347

Closed
wants to merge 3 commits into from

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Oct 31, 2023

I have written a Go program that is based on ValiadateKibanaNoDanglingObjectIDs lint from package-spec repository. It uses the same logic to find the dangling references and sets the correct parameters for yq to do in-place changes:

Example:

$ yq -i -I4 'del(.references.[] | .. | select(.id == "memcached-fleet-managed-default" and .type == "tag"))' kibana/dashboard/memcached-a36fa0b0-eccf-11ec-b66b-6bfdc9ecc703.json

I'll soon push that program so that other teams can also use the same to remove any dangling object ids. Very easy to use.

Proposed commit message

Address SVR00003 for memcached package i.e., removal of dangling object ids.

This is to address the skipped validation part of the package-spec v3 migration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Installs successfully and no obvious breakages in viz.

Related issues

@shmsr shmsr requested a review from a team as a code owner October 31, 2023 08:51
@shmsr
Copy link
Member Author

shmsr commented Oct 31, 2023

Should it be a bug-fix or an enhancement? Upon further consideration, I think enhancement here would be more apt?

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-02T09:38:51.441+0000

  • Duration: 14 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4) 👎 -22.368
Lines 100.0% (0/0) 💚 4.573
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1069,17 +1069,7 @@
"id": "metrics-*",
"name": "5061237a-3a71-485a-be3f-5d8e629e579e:indexpattern-datasource-layer-09bed68a-54a8-41fe-8e2f-6937efc350b4",
"type": "index-pattern"
},
{
"id": "memcached-fleet-managed-default",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shmsr : For my clarity, why do these pointers get created in the first place ?
They become dangling as I suppose the corresponding object gets removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you see the *.json, this is under references. References in the dashboard are used to establish relationships between different saved objects or components within Kibana.

Suppose you have 3 different viz that depend on the same index-pattern, so they could reference an index-pattern (e.g., metrics-*) that can be used by all 3 viz. So the id and name will be accordingly and the reference type will be index-pattern.

So this is a case for tags. There's no relationship currently being maintained with this reference.

If you see: #8348 (comment) you'll see some detailed examples of filters and their dependence on references (index-pattern).

@botelastic
Copy link

botelastic bot commented Dec 11, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 11, 2023
@mrodm
Copy link
Contributor

mrodm commented Dec 21, 2023

Hi @shmsr, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@botelastic botelastic bot removed the Stalled label Dec 21, 2023
@botelastic
Copy link

botelastic bot commented Jan 20, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 20, 2024
@shmsr
Copy link
Member Author

shmsr commented Feb 7, 2024

@devamanv Need you review here as well.

@botelastic botelastic bot removed the Stalled label Feb 7, 2024
@botelastic
Copy link

botelastic bot commented Mar 8, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 8, 2024
@botelastic
Copy link

botelastic bot commented Apr 7, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Apr 7, 2024
@ishleenk17
Copy link
Contributor

@shmsr : Still valid ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants