This repository has been archived by the owner on May 16, 2023. It is now read-only.
[meta] remove support for k8s <1.14 & helm <2.17.0 #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit remove the code support for k8s version < 1.14. This allows us to remove some helpers which aren't working anymore with Helm 2. In addition this also remove support for helm version < 2.17.0 which is the last Helm 2 version.
|
jenkins test this please |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Nov 20, 2020
This commit remove the code support for k8s version < 1.14. This allows us to remove some helpers which aren't working anymore with Helm 2. ``` Error: render error in "logstash/templates/statefulset.yaml": template: logstash/templates/_helpers.tpl:26:43: executing "logstash.statefulset.apiVersion" at <.Capabilities.KubeVersion.Version>: can't evaluate field Version in type *version.Info ``` In addition this also remove support for helm version < 2.17.0 which is the last Helm 2 version.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Nov 20, 2020
This commit remove the code support for k8s version < 1.14. This allows us to remove some helpers which aren't working anymore with Helm 2. ``` Error: render error in "logstash/templates/statefulset.yaml": template: logstash/templates/_helpers.tpl:26:43: executing "logstash.statefulset.apiVersion" at <.Capabilities.KubeVersion.Version>: can't evaluate field Version in type *version.Info ``` In addition this also remove support for helm version < 2.17.0 which is the last Helm 2 version.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Nov 20, 2020
This commit remove the code support for k8s version < 1.14. This allows us to remove some helpers which aren't working anymore with Helm 2. ``` Error: render error in "logstash/templates/statefulset.yaml": template: logstash/templates/_helpers.tpl:26:43: executing "logstash.statefulset.apiVersion" at <.Capabilities.KubeVersion.Version>: can't evaluate field Version in type *version.Info ``` In addition this also remove support for helm version < 2.17.0 which is the last Helm 2 version.
jmlrt
added a commit
that referenced
this pull request
Nov 20, 2020
This commit remove the code support for k8s version < 1.14. This allows us to remove some helpers which aren't working anymore with Helm 2. ``` Error: render error in "logstash/templates/statefulset.yaml": template: logstash/templates/_helpers.tpl:26:43: executing "logstash.statefulset.apiVersion" at <.Capabilities.KubeVersion.Version>: can't evaluate field Version in type *version.Info ``` In addition this also remove support for helm version < 2.17.0 which is the last Helm 2 version.
jmlrt
added a commit
that referenced
this pull request
Nov 20, 2020
This commit remove the code support for k8s version < 1.14. This allows us to remove some helpers which aren't working anymore with Helm 2. ``` Error: render error in "logstash/templates/statefulset.yaml": template: logstash/templates/_helpers.tpl:26:43: executing "logstash.statefulset.apiVersion" at <.Capabilities.KubeVersion.Version>: can't evaluate field Version in type *version.Info ``` In addition this also remove support for helm version < 2.17.0 which is the last Helm 2 version.
jmlrt
added a commit
that referenced
this pull request
Nov 20, 2020
Closed
This was referenced Feb 12, 2021
Merged
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove the code support for k8s version < 1.14.
This allows us to remove some helpers which aren't working anymore with
Helm 2.
In addition this also remove support for helm version < 2.17.0 which is
the last Helm 2 version.