Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Commit

Permalink
[7.10] [meta] remove support for k8s <1.14 & helm <2.17.0 (#916) (#922)
Browse files Browse the repository at this point in the history
This commit remove the code support for k8s version < 1.14.
This allows us to remove some helpers which aren't working anymore with
Helm 2.

```
Error: render error in "logstash/templates/statefulset.yaml": template: logstash/templates/_helpers.tpl:26:43: executing "logstash.statefulset.apiVersion" at <.Capabilities.KubeVersion.Version>: can't evaluate field Version in type *version.Info
```

In addition this also remove support for helm version < 2.17.0 which is
the last Helm 2 version.
  • Loading branch information
jmlrt authored Nov 20, 2020
1 parent 785546c commit 60b8922
Show file tree
Hide file tree
Showing 17 changed files with 20 additions and 94 deletions.
4 changes: 2 additions & 2 deletions apm-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ SLA of official GA features (see [supported configurations][] for more details).

## Requirements

* Kubernetes >= 1.9
* [Helm][] >= 2.8.0
* Kubernetes >= 1.14
* [Helm][] >= 2.17.0

See [supported configurations][] for more details.

Expand Down
17 changes: 0 additions & 17 deletions apm-server/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,6 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
{{- end -}}
{{- end -}}

{{/*
Return the appropriate apiVersion for ingress.
*/}}
{{- define "apm.ingress.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.Version -}}
{{- print "extensions/v1beta1" -}}
{{- else -}}
{{- print "networking.k8s.io/v1beta1" -}}
{{- end -}}
{{- end -}}
{{- define "apm.autoscaling.apiVersion" -}}
{{- if semverCompare "<1.12-0" .Capabilities.KubeVersion.Version -}}
{{- print "autoscaling/v2beta1" -}}
{{- else -}}
{{- print "autoscaling/v2beta2" -}}
{{- end -}}
{{- end -}}
{{/*
Use the fullname if the serviceAccount value is not set
*/}}
Expand Down
2 changes: 1 addition & 1 deletion apm-server/templates/hpa.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.autoscaling.enabled }}
apiVersion: {{ template "apm.autoscaling.apiVersion" . }}
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
metadata:
name: {{ template "apm.fullname" . }}
Expand Down
2 changes: 1 addition & 1 deletion apm-server/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- $fullName := include "apm.fullname" . -}}
{{- $servicePort := .Values.service.port -}}
{{- $ingressPath := .Values.ingress.path -}}
apiVersion: {{ template "apm.ingress.apiVersion" . }}
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
name: {{ template "apm.fullname" . }}
Expand Down
4 changes: 2 additions & 2 deletions elasticsearch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ This Helm chart is a lightweight way to configure and run our official

## Requirements

* [Helm][] >=2.8.0 and <3.0.0
* Kubernetes >=1.8
* Kubernetes >= 1.14
* [Helm][] >= 2.17.0
* Minimum cluster requirements include the following to run this chart with
default settings. All of these settings are configurable.
* Three Kubernetes nodes to respect the default "hard" affinity settings
Expand Down
22 changes: 0 additions & 22 deletions elasticsearch/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -63,25 +63,3 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
{{- end -}}
{{- end -}}
{{- end -}}

{{/*
Return the appropriate apiVersion for statefulset.
*/}}
{{- define "elasticsearch.statefulset.apiVersion" -}}
{{- if semverCompare "<1.9-0" .Capabilities.KubeVersion.Version -}}
{{- print "apps/v1beta2" -}}
{{- else -}}
{{- print "apps/v1" -}}
{{- end -}}
{{- end -}}

{{/*
Return the appropriate apiVersion for ingress.
*/}}
{{- define "elasticsearch.ingress.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.Version -}}
{{- print "extensions/v1beta1" -}}
{{- else -}}
{{- print "networking.k8s.io/v1beta1" -}}
{{- end -}}
{{- end -}}
2 changes: 1 addition & 1 deletion elasticsearch/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- $fullName := include "elasticsearch.uname" . -}}
{{- $servicePort := .Values.httpPort -}}
{{- $ingressPath := .Values.ingress.path -}}
apiVersion: {{ template "elasticsearch.ingress.apiVersion" . }}
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
name: {{ $fullName }}
Expand Down
4 changes: 1 addition & 3 deletions elasticsearch/templates/statefulset.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
apiVersion: {{ template "elasticsearch.statefulset.apiVersion" . }}
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: {{ template "elasticsearch.uname" . }}
Expand Down Expand Up @@ -152,9 +152,7 @@ spec:
imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 8 }}
{{- end }}
{{- if semverCompare ">1.13-0" .Capabilities.KubeVersion.Version }}
enableServiceLinks: {{ .Values.enableServiceLinks }}
{{- end }}
initContainers:
{{- if .Values.sysctlInitContainer.enabled }}
- name: configure-sysctl
Expand Down
4 changes: 2 additions & 2 deletions filebeat/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ This Helm chart is a lightweight way to configure and run our official

## Requirements

* [Helm][] >=2.8.0 and <3.0.0
* Kubernetes >=1.9
* Kubernetes >= 1.14
* [Helm][] >= 2.17.0

See [supported configurations][] for more details.

Expand Down
4 changes: 2 additions & 2 deletions kibana/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ This Helm chart is a lightweight way to configure and run our official

## Requirements

* [Helm][] >=2.8.0 and <3.0.0
* Kubernetes >=1.9
* Kubernetes >= 1.14
* [Helm][] >= 2.17.0

See [supported configurations][] for more details.

Expand Down
11 changes: 0 additions & 11 deletions kibana/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,6 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
{{- end -}}
{{- end -}}

{{/*
Return the appropriate apiVersion for ingress.
*/}}
{{- define "kibana.ingress.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.Version -}}
{{- print "extensions/v1beta1" -}}
{{- else -}}
{{- print "networking.k8s.io/v1beta1" -}}
{{- end -}}
{{- end -}}

{{/*
Common labels
*/}}
Expand Down
2 changes: 1 addition & 1 deletion kibana/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{- $fullName := include "kibana.fullname" . -}}
{{- $servicePort := .Values.service.port -}}
{{- $ingressPath := .Values.ingress.path -}}
apiVersion: {{ template "kibana.ingress.apiVersion" . }}
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
name: {{ $fullName }}
Expand Down
4 changes: 2 additions & 2 deletions logstash/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ SLA of official GA features (see [supported configurations][] for more details).

## Requirements

* [Helm][] >=2.8.0 and <3.0.0
* Kubernetes >=1.8
* Kubernetes >= 1.14
* [Helm][] >= 2.17.0

See [supported configurations][] for more details.

Expand Down
22 changes: 0 additions & 22 deletions logstash/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,3 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

{{/*
Return the appropriate apiVersion for statefulset.
*/}}
{{- define "logstash.statefulset.apiVersion" -}}
{{- if semverCompare "<1.9-0" .Capabilities.KubeVersion.Version -}}
{{- print "apps/v1beta2" -}}
{{- else -}}
{{- print "apps/v1" -}}
{{- end -}}
{{- end -}}

{{/*
Return the appropriate apiVersion for ingress.
*/}}
{{- define "logstash.ingress.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.Version -}}
{{- print "extensions/v1beta1" -}}
{{- else -}}
{{- print "networking.k8s.io/v1beta1" -}}
{{- end -}}
{{- end -}}
4 changes: 2 additions & 2 deletions logstash/templates/ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{- if .Values.ingress.enabled -}}
{{- $fullName := include "logstash.fullname" . -}}
apiVersion: {{ template "logstash.ingress.apiVersion" . }}
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
name: {{ $fullName }}
Expand Down Expand Up @@ -28,6 +28,6 @@ spec:
backend:
serviceName: {{ $fullName }}
servicePort: {{ .servicePort }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion logstash/templates/statefulset.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
apiVersion: {{ template "logstash.statefulset.apiVersion" . }}
apiVersion: apps/v1
kind: StatefulSet
metadata:
name: {{ template "logstash.fullname" . }}
Expand Down
4 changes: 2 additions & 2 deletions metricbeat/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ This Helm chart is a lightweight way to configure and run our official

## Requirements

* [Helm][] >=2.8.0 and <3.0.0
* Kubernetes >=1.9
* Kubernetes >= 1.14
* [Helm][] >= 2.17.0

See [supported configurations][] for more details.

Expand Down

0 comments on commit 60b8922

Please sign in to comment.