Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Remove defaultProps from function components #7297

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[Tech debt] Remove defaultProps from function components #7297

merged 4 commits into from
Oct 19, 2023

Commits on Oct 18, 2023

  1. [docs] Convert basic .defaultProps usage

    @cee-chen
    cee-chen committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    a3bf45d View commit details
    Browse the repository at this point in the history

  2. [docs] convert currentRoute usage 

    - remove totally unused prop
- convert other to `= {}` fallback
    @cee-chen
    cee-chen committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    2e3ce20 View commit details
    Browse the repository at this point in the history

  3. [EuiFieldPassword] Convert basic .defaultProps

    @cee-chen
    cee-chen committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7721d8a View commit details
    Browse the repository at this point in the history

  4. [EuiInputPopover] Convert .defaultProps + a improve props documenta… 

    …tion

- a few hard-coded props (that were present in the table) should have been defined in the destructure fallbacks, so that their defaults display in our docs prop table
    @cee-chen
    cee-chen committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1b60ba2 View commit details
    Browse the repository at this point in the history