[Tech debt] Remove defaultProps from function components
#7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove totally unused prop
- convert other to `= {}` fallback
…tion - a few hard-coded props (that were present in the table) should have been defined in the destructure fallbacks, so that their defaults display in our docs prop table
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
JasonStoltz
reviewed
Oct 19, 2023
|
|
||
| AppContext.propTypes = { | ||
| children: PropTypes.any, | ||
| currentRoute: PropTypes.object.isRequired, |
There was a problem hiding this comment.
Did we lose this or is it just no longer neccessary?
There was a problem hiding this comment.
Not necessary - it wasn't even being used, so my guess was it was a bad copy/paste job
JasonStoltz
approved these changes
Oct 19, 2023
|
Thanks for the review Jason! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #7287 (NOTE: Does not close the issue fully - we need #7296 for that as well)
React 18 is deprecating support for
defaultProps- this PR removes all instances of function componentdefaultProps, and also checks that all props tables in our docs work as expected.QA
falseforisLoadingandcompressedanchorPosition,attachToAnchor,repositionToCrossAxis,display,panelPaddingSize, andownFocus(compare to the defaultEuiPopoverprops)General checklist
@defaultif default values are missing)and playground toggles