Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third-party logos optimization #2812

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Third-party logos optimization #2812

merged 4 commits into from
Feb 4, 2020

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented Jan 31, 2020 •
edited
Loading

Summary

Closes #2780

The icons Ceph, DropWizard, Golang, and Haproxy used to have a PNG embedded in the SVG. I replaced those icons with vector versions.

logos size

icons-optimization

The icons were also updated in our Figma library

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested a review from snide January 31, 2020 14:22
@pugnascotia
Copy link
Contributor

I ❤️ this PR

@elizabetdev elizabetdev requested a review from cchaos February 4, 2020 12:36
cchaos
cchaos approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, the only logos that were touched were Ceph, DropWizard, Golang, and Haproxy. I would mention these in the PR summary and the Changelog, otherwise it's unclear which ones were actually optimized.

Those 4 look good though. 👍

@elizabetdev
Copy link
Contributor Author

The changelog and the PR summary are now updated with the logos that were optimized. 🎉

@elizabetdev
Copy link
Contributor Author

jenkins test this

@elizabetdev elizabetdev merged commit c99dcec into elastic:master Feb 4, 2020
@thompsongl thompsongl mentioned this pull request Feb 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some icon asset SVGs are huge
3 participants
@elizabetdev @pugnascotia @cchaos