Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EuiTablePlus #236

Closed
wants to merge 3 commits into from
Closed

Add EuiTablePlus #236

wants to merge 3 commits into from

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Dec 21, 2017

@uboness @bmcconaghy Could you take a look at this interface and functionality and give me feedback? Thanks.

To-do

  • Add onSelectionChange callback prop
  • Add search functionality
  • Search as you type or on enter
  • Add sort functionality
  • Allow consumer to specify pagination options
  • Improve tests and use mocks to abstract parts of the snapshots
  • Update CHANGELOG
  • Update docs with an explanation of TablePlus
  • Disable row selection
  • "tool bar" area for actions or info
  • Standardized row renderers
  • Add links in docs from Table to TablePlus

@cjcenizal
Copy link
Contributor Author

@stacey-gammon I imagine that this will replace KuiListingTable. Would you mind taking a look and letting me know what you think?

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Dec 21, 2017

Closing this in favor of @uboness's implementation. Though I still think we should use the name EuiTablePlus!

@cjcenizal cjcenizal closed this Dec 21, 2017
@cjcenizal cjcenizal deleted the super-table branch December 21, 2017 17:10
@cjcenizal
Copy link
Contributor Author

Note to self: I want to use this component to replace the paginated_table in Kibana, similar to what was done in elastic/kibana#14948. That PR uncovered some unexpected use cases, like editable cells, so we'll want to make sure we understand them all and accommodate them with what we come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant