Fix bug with Pager service when there are no items.

elastic · Dec 21, 2017 · 50a771e · 50a771e
1 parent bd05694
commit 50a771e
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/services/paging/pager.js b/src/services/paging/pager.js
@@ -55,6 +55,14 @@ export class Pager {
   }
 
   update = () => {
+    if (this.totalItems <= 0) {
+      this.totalPages = 0;
+      this.currentPageIndex = 0;
+      this.firstItemIndex = 0;
+      this.lastItemIndex = 0;
+      return;
+    }
+
     this.totalPages = Math.ceil(this.totalItems / this.itemsPerPage);
 
     // Ensure the current page falls within our range of total pages.

diff --git a/src/services/paging/pager.test.js b/src/services/paging/pager.test.js
@@ -137,4 +137,18 @@ describe('Pager', () => {
       });
     });
   });
+
+  describe('behavior', () => {
+    describe('when there are no items', () => {
+      test('getFirstItemIndex defaults to 0', () => {
+        const pager = new Pager(0, 20);
+        expect(pager.getFirstItemIndex()).toBe(0);
+      });
+
+      test('getLastItemIndex defaults to 0', () => {
+        const pager = new Pager(0, 20);
+        expect(pager.getLastItemIndex()).toBe(0);
+      });
+    });
+  });
 });