Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally set attributes in EuiMutationObserver options #2180

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Conditionally set attributes in EuiMutationObserver options #2180

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7a8975d
add attributes option
thompsongl Jul 23, 2019
ecd4909
Merge branch 'master' into accordion-observer-attributes
thompsongl Jul 30, 2019
a64b56e
CL
thompsongl Jul 30, 2019
0ce142e
use mutationObserver as the keeper of spec logic
thompsongl Jul 31, 2019
a243dad
update CL
thompsongl Jul 31, 2019
fed32cf
clone
thompsongl Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `13.1.0`.
**Bug fixes**

- Fixed `EuiAccordion` using `MutationObserver` in IE11 by adding `attributes` to the observer options ([#2180](https://github.com/elastic/eui/pull/2180))

## [`13.1.0`](https://github.com/elastic/eui/tree/v13.1.0)

Expand Down
2 changes: 2 additions & 0 deletions src/components/accordion/__snapshots__/accordion.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ exports[`EuiAccordion behavior closes when clicked twice 1`] = `
"attributeFilter": Array [
"style",
],
"attributes": true,
"childList": true,
"subtree": true,
}
Expand Down Expand Up @@ -131,6 +132,7 @@ exports[`EuiAccordion behavior opens when clicked once 1`] = `
"attributeFilter": Array [
"style",
],
"attributes": true,
"childList": true,
"subtree": true,
}
Expand Down
1 change: 1 addition & 0 deletions src/components/accordion/accordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ export class EuiAccordion extends Component<
observerOptions={{
childList: true,
subtree: true,
attributes: true,
thompsongl marked this conversation as resolved.
Show resolved Hide resolved
attributeFilter: MUTATION_ATTRIBUTE_FILTER,
}}
onMutation={this.onMutation}>
Expand Down