Conditionally set attributes in EuiMutationObserver options
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
Jul 30, 2019
thompsongl
changed the title
attributes to EuiAccordion MutationObserver optionsattributes in EuiMutationObserver options
chandlerprall
suggested changes
Jul 31, 2019
3 tasks
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
…tic#2180) * add attributes option * CL * use mutationObserver as the keeper of spec logic * update CL * clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resurrecting #2159.
Originally, we thought that the errors were caused by an incorrectly implemented
MutationObserverpolyfill, but it's more likely that the spec has been updated since both the polyfill and IE11 implemented the spec.Adding
attributesto the observer options correctly applies theattributesFilteroption and prevents errors in IE11.Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes