Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up svg defs and ids #2169

Merged
merged 5 commits into from
Jul 29, 2019
Merged

Clean up svg defs and ids #2169

merged 5 commits into from
Jul 29, 2019

Conversation

mdefazio
Copy link
Contributor

Ref: #2162

Summary

Closes #1989
Removes <use> and <def> from svg icons.

Checklist

  • [ ] This was checked in mobile-
  • [ ] This was checked in IE11-
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎉

@mdefazio mdefazio merged commit fbe7f1b into elastic:master Jul 29, 2019
@mdefazio mdefazio deleted the icons/svg-defs branch July 29, 2019 20:00
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
* Fix elastic#1989

* Update CHANGELOG

* Update icons to remove extra ids and defs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up icon <defs> and <use> usages
2 participants