Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up icon <defs> and <use> usages #1989

Closed
cchaos opened this issue Jun 3, 2019 · 1 comment · Fixed by #2169
Closed

Clean up icon <defs> and <use> usages #1989

cchaos opened this issue Jun 3, 2019 · 1 comment · Fixed by #2169
Labels
chore good first issue

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 3, 2019

Theres no need for individual SVG's to use this pattern as it just creates issues like #1985 and more calculation for the SVG to do. It also creates some unnecessary generic id names that can cause duplicate id's to occur on the same page.

Screen Shot 2019-06-03 at 11 13 18 AM
@cchaos cchaos mentioned this issue Jun 3, 2019
Merged
10 tasks
@snide snide added the chore label Jun 11, 2019
@cchaos
Copy link
Contributor Author

cchaos commented Jun 14, 2019

Clarification:

<defs> and <use> should be removed, not added 🥂

@cchaos cchaos mentioned this issue Jul 22, 2019
Closed
mdefazio added a commit to mdefazio/eui that referenced this issue Jul 24, 2019
@mdefazio
Fix elastic#1989
0022e1d
@mdefazio mdefazio mentioned this issue Jul 24, 2019
Closed
1 task
mdefazio added a commit to mdefazio/eui that referenced this issue Jul 25, 2019
@mdefazio
Fix elastic#1989
9370918
snide pushed a commit to snide/eui that referenced this issue Jul 25, 2019
@mdefazio @snide
Fix elastic#1989
8668630
mdefazio added a commit to mdefazio/eui that referenced this issue Jul 25, 2019
@mdefazio
Fix elastic#1989
088b518
@mdefazio mdefazio mentioned this issue Jul 25, 2019
Merged
1 task
mdefazio added a commit that referenced this issue Jul 29, 2019
@mdefazio
Clean up svg defs and ids (#2169)
fbe7f1b 
* Fix #1989

* Update CHANGELOG

* Update icons to remove extra ids and defs
thompsongl pushed a commit to thompsongl/eui that referenced this issue Sep 10, 2019
@mdefazio @thompsongl
Clean up svg defs and ids (elastic#2169)
8baf8b7 
* Fix elastic#1989

* Update CHANGELOG

* Update icons to remove extra ids and defs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up svg defs and ids mdefazio/eui
Removes <use> and <def> from svg icons mdefazio/eui
2 participants
@snide @cchaos