-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definitions to EuiSuperSelect #1752 #1907
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
805c1a4
Add type definitions to EuiSuperSelect #1752
wylieconlon 5d1428c
Merge remote-tracking branch 'origin/master' into super-select-types
wylieconlon ec4a09d
Correctly make EuiSuperSelect props optional, except options.value
wylieconlon 2139203
Merge remote-tracking branch 'origin/master' into super-select-types
wylieconlon abb643b
Move changelog to latest
wylieconlon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
import { CommonProps } from '../../common'; | ||
|
||
import {FunctionComponent, ReactNode, ButtonHTMLAttributes} from 'react'; | ||
|
||
declare module '@elastic/eui' { | ||
/** | ||
* @see './super_select.js' | ||
*/ | ||
|
||
export type EuiSuperSelectProps = CommonProps & ButtonHTMLAttributes<HTMLButtonElement> & { | ||
/** | ||
* Classes for the context menu item | ||
*/ | ||
itemClassName: string; | ||
|
||
/** | ||
* You must pass an `onChange` function to handle the update of the value | ||
*/ | ||
onChange: (value: string) => void; | ||
|
||
/** | ||
* Pass an array of options that must at least include: | ||
* `value`: storing unique value of item, | ||
* `inputDisplay`: what shows inside the form input when selected | ||
* `dropdownDisplay` (optional): what shows for the item in the dropdown | ||
*/ | ||
options?: Array<{ | ||
value: string; | ||
inputDisplay: ReactNode; | ||
dropdownDisplay?: ReactNode; | ||
}>; | ||
|
||
valueOfSelected: string; | ||
|
||
/** | ||
* Change to `true` if you want horizontal lines between options. | ||
* This is best used when options are multi-line. | ||
*/ | ||
hasDividers?: boolean; | ||
|
||
/** | ||
* Change `EuiContextMenuItem` layout position of icon | ||
*/ | ||
itemLayoutAlign: string; | ||
|
||
/** | ||
* Make it wide. Default: false | ||
*/ | ||
fullWidth?: boolean; | ||
|
||
/** | ||
* Provides invalid styling. Default: false | ||
*/ | ||
isInvalid?: boolean; | ||
|
||
/** | ||
* Make it short. Default: false | ||
*/ | ||
compressed?: boolean; | ||
|
||
/** | ||
* Applied to the outermost wrapper (popover) | ||
*/ | ||
popoverClassName: string; | ||
|
||
/** | ||
* Controls whether the options are shown. Default: false | ||
*/ | ||
isOpen?: boolean; | ||
|
||
}; | ||
|
||
export const EuiSuperSelect: FunctionComponent<EuiSuperSelectProps>; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to move this back up to master so it doesn't get tied to an old release.