-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type definitions to EuiSuperSelect #1752 #1907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wylieconlon I think a lot of your defs got reversed. ?:
for optional, :
for required. Looks like a lot of them just need to be flipped.
Hi @snide I followed the optional/required definitions from the PropTypes documentation. If you see any specific properties I missed, could you comment on the lines? I don't see any. |
Specifically, the PropTypes indicate that these have defaults and are therefore optional:
|
The existing proptypes are the main source of whether a prop is required or optional (with the code itself as the true authority, but ideally the proptypes are correct!). For SuperSelect, only Props that do not have a default value listed in the props may still be optional as the component can compare with |
Thanks, I'll make these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changelog issue, otherwise lgtm.
CHANGELOG.md
Outdated
@@ -19,6 +19,7 @@ | |||
- Added support for `href` on the last item in `EuiBreadcrumbs` ([#1905](https://github.com/elastic/eui/pull/1905)) | |||
- Added `selectable` prop to `EuiCard` ([#1895](https://github.com/elastic/eui/pull/1895)) | |||
- Converted `EuiValidatableControl` to TS ([#1879](https://github.com/elastic/eui/pull/1879)) | |||
- Add type definitions to `EuiSuperSelect` ([##1752](https://github.com/elastic/eui/issues/1752)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to move this back up to master so it doesn't get tied to an old release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Adds types to EuiSuperSelect. Closes #1752
Checklist