-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-datepicker as an eui package #1337
Add react-datepicker as an eui package #1337
Conversation
WIP. Jumping in here to fix some stylings. |
…ui into feature/react-datepicker
@chandlerprall In styling this I noticed two bugs, one big, one small.
Otherwise I think we're good to go here. |
cannot reproduce (talked with Dave, neither can he)
I verified this will be fixed when we upgrade |
…, set seconds to 0 when a time is selected, correct the arrow key interaction with month dropdown selection
@snide Pushed a couple small bug (below), everything should be ready for review.
|
FYI this is only a problem with our implementation cuz i was doing CSS stupidity. But I'm ok with changing that here, it's just something to remember if we ever have to break it back out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a small issue where the global datepicker one does not seem to have the accessible class to highlight the calendar. Otherwise I ran through all my tests and your fixes and this seems to work!
This looks to be because it is missing the accessible classname. FWIW, the accessibility still works there, the class is just missing.
Pushed an update to fix that calendar class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Bringing in
react-datepicker
as an internal package in EUI.