ESQL: Improve agg verification #99827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Hi @alex-spies, I've created a changelog YAML for you. |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
|
This might need to be (adapted and) merged after #99602 since support for |
alex-spies
changed the title
bpintea
approved these changes
Oct 2, 2023
...l/src/main/java/org/elasticsearch/xpack/esql/planner/AbstractPhysicalOperationProviders.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Verifier.java
Show resolved
Hide resolved
|
@bpintea , I took care of the type resolution bug in |
costin
approved these changes
Oct 6, 2023
x-pack/plugin/ql/src/main/java/org/elasticsearch/xpack/ql/expression/Expression.java
Outdated
Show resolved
Hide resolved
|
Likely this has to go in 8.11 as well. |
|
Hi @alex-spies, I've updated the changelog YAML for you. |
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
alex-spies
added
the
buildkite-opt-in
|
@elasticsearchmachine run elasticsearch-ci/part-1 |
|
Hi @alex-spies, I've updated the changelog YAML for you. |
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Oct 6, 2023
When verifying aggregation expressions like from employees | stats percentile(salary_change, 25*2) , both arguments are treated the same way during verification. This is incorrect, as salary_change is the actual aggregation's field, while 25*2 is merely it's (first and only) parameter. This is overly restrictive. Apply the current verification only to the aggregation's actual field, as the parameter is already verified during type resolution (it needs to be a constant expression).
💚 Backport successful
|
alex-spies
added a commit
that referenced
this pull request
Oct 9, 2023
When verifying aggregation expressions like from employees | stats percentile(salary_change, 25*2) , both arguments are treated the same way during verification. This is incorrect, as salary_change is the actual aggregation's field, while 25*2 is merely it's (first and only) parameter. This is overly restrictive. Apply the current verification only to the aggregation's actual field, as the parameter is already verified during type resolution (it needs to be a constant expression).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99751.Update: fix for #99751 is already contained in #99602. I'm keeping this PR open for additional verification improvements, though.When verifying aggregation expressions like
from employees | stats percentile(salary_change, 25*2), both arguments are treated the same way during verification. This is incorrect, assalary_changeis the actual aggregation's field, while25*2is merely it's (first and only) parameter. This is overly restrictive.Apply the current verification only to the aggregation's actual field, as the parameter is already verified during type resolution (it needs to be a constant expression).