[8.11] ESQL: Improve agg verification (#99827) #100414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When verifying aggregation expressions like from employees | stats percentile(salary_change, 25*2) , both arguments are treated the same way during verification. This is incorrect, as salary_change is the actual aggregation's field, while 25*2 is merely it's (first and only) parameter. This is overly restrictive. Apply the current verification only to the aggregation's actual field, as the parameter is already verified during type resolution (it needs to be a constant expression).
alex-spies
added
:Analytics/ES|QL
|
@elasticsearchmachine run elasticsearch-ci |
alex-spies
removed
the
buildkite-opt-in
|
Hm, the buildkite CI failed because this does not seem to apply to backports. Since this was only needed as workaround to a Jenkins CI bug on the main PR, and the Jenkins CI seems to have gone fine for this backport, this should be fine to be merged. |
|
@elasticsearchmachine update branch |
bpintea
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.11: