Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable concurrency for MoreExpressionIT #99203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable concurrency for MoreExpressionIT #99203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da711f
Disable concurrency for MoreExpressionIT
JVerwolf Sep 5, 2023
03d553d
Merge branch 'main' of github.com:elastic/elasticsearch into testfix/…
JVerwolf Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...on/src/internalClusterTest/java/org/elasticsearch/script/expression/MoreExpressionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,16 @@ public void testInvalidFieldMember() {
}
}

/**
* We have seen `testSpecialValueVariable()` fail in CI due to concurrency issues.
* We will disable concurrency here so that this doesn't cause flakey CI, then follow up with a subsequent fix.
* Ref: <a href="https://github.com/elastic/elasticsearch/issues/99156">Test failure issue</a>
*/
@Override
protected boolean enableConcurrentSearch() {
return false;
}

public void testSpecialValueVariable() throws Exception {
// i.e. _value for aggregations
createIndex("test");
Expand Down