Disable concurrency for MoreExpressionIT #99203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVerwolf
added
>test
|
Pinging @elastic/es-search (Team:Search) |
|
@elasticsearchmachine packaging-tests-unix-sample |
|
@elasticsearchmachine run packaging-tests-unix-sample |
|
@elasticsearchmachine run elasticsearch-ci/packaging-tests-unix-sample |
…testSpecialValueVariable
thecoop
approved these changes
Sep 6, 2023
|
This is good as a short-term workaround, in that it will make tests go green. Ideally though, we would try to disable concurrency for the specific functionality that causes issues, rather than disabling concurrency in the specific test. |
|
retest! |
|
I opened #99667 to fix the root cause. I think that we can keep concurrency enabled in this test, it helped us find a production bug. |
javanna
added
:Search Foundations/Search
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dissables concurrency for the flakey test reported in #99156
Reference to the original issue to enable concurrency in just the tests: #98567