-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Remove breaking change tags #98144
Merged
jrodewig
merged 4 commits into
elastic:main
from
jrodewig:remove-notable-breaking-change-tags
Aug 3, 2023
Merged
[DOCS] Remove breaking change tags #98144
jrodewig
merged 4 commits into
elastic:main
from
jrodewig:remove-notable-breaking-change-tags
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
jrodewig
added
>docs
General docs changes
Team:Docs
Meta label for docs team
Team:Delivery
Meta label for Delivery team
:Delivery/Tooling
Developer tooliing and automation
v8.9.0
labels
Aug 2, 2023
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-delivery (Team:Delivery) |
abdonpijpelink
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jrodewig
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Delivery/Tooling
Developer tooliing and automation
>docs
General docs changes
Team:Delivery
Meta label for Delivery team
Team:Docs
Meta label for docs team
v8.9.0
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With elastic/stack-docs#2495 merged, we no longer reuse breaking changes in the Stack Install/Upgrade guide.
This removes the related
notable-breaking-changes[]
tags from the 8.9+ docs and updates the RN generator template.Out of scope
With the removal of these tags, we may no longer need the
notable
property for changelog entries and can likely simplify the logic for the BreakingChangesGenerator. Updating those files is outside the scope of this PR. I've opened #98145 to track that work.