Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove breaking change tags #98144

Merged
merged 4 commits into from
Aug 3, 2023
Merged

[DOCS] Remove breaking change tags #98144

merged 4 commits into from
Aug 3, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 2, 2023

With elastic/stack-docs#2495 merged, we no longer reuse breaking changes in the Stack Install/Upgrade guide.

This removes the related notable-breaking-changes[] tags from the 8.9+ docs and updates the RN generator template.

Out of scope

With the removal of these tags, we may no longer need the notable property for changelog entries and can likely simplify the logic for the BreakingChangesGenerator. Updating those files is outside the scope of this PR. I've opened #98145 to track that work.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Documentation preview:

@jrodewig jrodewig added >docs General docs changes Team:Docs Meta label for docs team Team:Delivery Meta label for Delivery team :Delivery/Tooling Developer tooliing and automation v8.9.0 labels Aug 2, 2023
@jrodewig jrodewig requested review from a team August 2, 2023 21:13
@jrodewig jrodewig marked this pull request as ready for review August 2, 2023 21:15
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit e00b354 into elastic:main Aug 3, 2023
@jrodewig jrodewig deleted the remove-notable-breaking-change-tags branch August 3, 2023 19:23
@jrodewig
Copy link
Contributor Author

jrodewig commented Aug 3, 2023

💚 All backports created successfully

Status Branch Result
8.9

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Tooling Developer tooliing and automation >docs General docs changes Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants