Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN Generation] Remove 'notable' logic from the breaking changes generator #98145

Closed
jrodewig opened this issue Aug 2, 2023 · 1 comment
Closed
Labels
:Delivery/Tooling Developer tooliing and automation >enhancement Team:Delivery Meta label for Delivery team

Comments

@jrodewig
Copy link
Contributor

jrodewig commented Aug 2, 2023

Description

With elastic/stack-docs#2495 merged, we no longer reuse breaking changes in the Stack Install/Upgrade guide. I'm removing related notable-breaking-changes[] tags from the docs in #98144.

With the removal of these tags, we may no longer need the notable property for changelog entries. We can also likely simplify the logic for the BreakingChangesGenerator.

@jrodewig jrodewig added >enhancement :Delivery/Tooling Developer tooliing and automation labels Aug 2, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Aug 2, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jrodewig jrodewig changed the title [RN Generation] Simplify the logic of the release notes generator [RN Generation] Remove 'notable' logic from the breaking changes generator Aug 2, 2023
jrodewig added a commit that referenced this issue Aug 3, 2023
With elastic/stack-docs#2495 merged, we no longer reuse breaking changes in the Stack Install/Upgrade guide.

This removes the related `notable-breaking-changes[]` tags from the 8.9+ docs and updates the RN generator template.

## Out of scope
With the removal of these tags, we may no longer need the `notable` property for changelog entries and can likely simplify the logic for the [BreakingChangesGenerator](https://github.com/elastic/elasticsearch/blob/main/build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/release/BreakingChangesGenerator.java). Updating those files is outside the scope of this PR. I've opened #98145 to track that work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Tooling Developer tooliing and automation >enhancement Team:Delivery Meta label for Delivery team
Projects
None yet
Development

No branches or pull requests

2 participants