Busy wait until all tasks are removed #95494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a small delay between we release the main task and all the tasks actually get removed from the task manager, make sure we don't fail the test immediately, but busy wait a bit.
arteam
added
>test
|
@elasticmachine update branch |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Do we know why this started failing? |
|
I wonder if this is also related to #94987 (comment). |
|
Yeah, it's definitely related to #94987 (comment) |
|
There have been a few task related test failures due to #94865 |
original-brownbear
approved these changes
Apr 24, 2023
| try { | ||
| assertBusy(() -> assertEquals(0, node.transportService.getTaskManager().getTasks().size())); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
NIT: Maybe just add throws Exception to this method and all its callers? :)
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Apr 26, 2023
Due to elastic#94865, we now send an ack before the task gets removed, so we can see a non-zero amount of tasks in the task manager for a short amount of time. We can just busy wait until the task gets removed. See elastic#95494, elastic#94987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a small delay between we release the main task and all the tasks actually get removed from the task manager, make sure we don't fail the test immediately, but busy wait a bit.
Fixes #95425