Close task after calling sendResponse() #94865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we unregister transport tasks before calling `TransportChannel#sendResponse` in order to send back the response. Yet the serialization and transmission work is still really part of the task's work, so we should keep the task around until these parts are done too. This commit delays the task unregistration until after `sendResponse` returns, which is simple to achieve. Delaying it until the end of transmission is a little harder and will be the subject of future work. Relates elastic#94845
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Mar 29, 2023
idegtiarenko
approved these changes
Mar 29, 2023
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2023-03-29-close-task-after-channel-sendResponse
branch
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2023
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Apr 26, 2023
Due to elastic#94865, we now send an ack before the task gets removed, so we can see a non-zero amount of tasks in the task manager for a short amount of time. We can just busy wait until the task gets removed. See elastic#95494, elastic#94987
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we unregister transport tasks before calling
TransportChannel#sendResponsein order to send back the response. Yet the serialization and transmission work is still really part of the task's work, so we should keep the task around until these parts are done too.This commit delays the task unregistration until after
sendResponsereturns, which is simple to achieve. Delaying it until the end of transmission is a little harder and will be the subject of future work.Relates #94845