Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeper chunking of node stats response #95060

Merged

Conversation

DaveCTurner
Copy link
Contributor

Pushes the chunking of GET _nodes/stats down to avoid creating unboundedly large chunks. With this commit we yield one chunk per shard (if ?level=shards) or index (if ?level=indices) and per HTTP client and per transport action.

Closes #93985

Pushes the chunking of `GET _nodes/stats` down to avoid creating
unboundedly large chunks. With this commit we yield one chunk per shard
(if `?level=shards`) or index (if `?level=indices`) and per HTTP client
and per transport action.

Closes elastic#93985
@DaveCTurner DaveCTurner added >non-issue :Data Management/Stats Statistics tracking and retrieval APIs v8.8.0 labels Apr 5, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Apr 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did my best to make sure the format didn't change anywhere but looks fine 🤞 :)

@DaveCTurner
Copy link
Contributor Author

did my best to make sure the format didn't change anywhere

me too :)

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 5, 2023
@DaveCTurner
Copy link
Contributor Author

@elasticmachine please run elasticsearch-ci/part-1

@elasticsearchmachine elasticsearchmachine merged commit c282f50 into elastic:main Apr 6, 2023
@DaveCTurner DaveCTurner deleted the 2023-04-05-node-stats-chunking branch April 6, 2023 05:27
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Apr 6, 2023
Ingest stats are O(pipelines*processors) too, and that could be quite a
large amount of data in some cases.

Relates elastic#95060
DaveCTurner added a commit that referenced this pull request Apr 6, 2023
Ingest stats are O(pipelines*processors) too, and that could be quite a
large amount of data in some cases.

Relates #95060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Stats Statistics tracking and retrieval APIs >non-issue Team:Data Management Meta label for data/management team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deeper chunking of node stats response
3 participants