-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deeper chunking of node stats response #95060
Merged
elasticsearchmachine
merged 3 commits into
elastic:main
from
DaveCTurner:2023-04-05-node-stats-chunking
Apr 6, 2023
Merged
Deeper chunking of node stats response #95060
elasticsearchmachine
merged 3 commits into
elastic:main
from
DaveCTurner:2023-04-05-node-stats-chunking
Apr 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushes the chunking of `GET _nodes/stats` down to avoid creating unboundedly large chunks. With this commit we yield one chunk per shard (if `?level=shards`) or index (if `?level=indices`) and per HTTP client and per transport action. Closes elastic#93985
DaveCTurner
added
>non-issue
:Data Management/Stats
Statistics tracking and retrieval APIs
v8.8.0
labels
Apr 5, 2023
elasticsearchmachine
added
the
Team:Data Management
Meta label for data/management team
label
Apr 5, 2023
Pinging @elastic/es-data-management (Team:Data Management) |
original-brownbear
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, did my best to make sure the format didn't change anywhere but looks fine 🤞 :)
me too :) |
DaveCTurner
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Apr 5, 2023
@elasticmachine please run elasticsearch-ci/part-1 |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 6, 2023
Ingest stats are O(pipelines*processors) too, and that could be quite a large amount of data in some cases. Relates elastic#95060
DaveCTurner
added a commit
that referenced
this pull request
Apr 6, 2023
Ingest stats are O(pipelines*processors) too, and that could be quite a large amount of data in some cases. Relates #95060
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Data Management/Stats
Statistics tracking and retrieval APIs
>non-issue
Team:Data Management
Meta label for data/management team
v8.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes the chunking of
GET _nodes/stats
down to avoid creating unboundedly large chunks. With this commit we yield one chunk per shard (if?level=shards
) or index (if?level=indices
) and per HTTP client and per transport action.Closes #93985